Skip to content

mini update 3: fill in overview section#160

Merged
vbatts merged 3 commits intoopencontainers:reorgfrom
bloodorangeio:mini-update-3
Jun 29, 2020
Merged

mini update 3: fill in overview section#160
vbatts merged 3 commits intoopencontainers:reorgfrom
bloodorangeio:mini-update-3

Conversation

@jdolitsky
Copy link
Copy Markdown
Contributor

Fill in the overview section, including new introduction
referring to "content" (vs. just container images).

Move historical context section underneath overview.


This PR is built on top of #159, so the diff is misleading. Please see the following for a true diff: bloodorangeio/distribution-spec@mini-update-2...bloodorangeio:mini-update-3

Fill in the overview section, including new introduction
referring to "content" (vs. just container images).

Move historical context section underneath overview.

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Comment thread spec.md

The key words "unspecified", "undefined", and "implementation-defined" are to be interpreted as described in the [rationale for the C99 standard][c99-unspecified].

An implementation is not compliant if it fails to satisfy one or more of the MUST, MUST NOT, REQUIRED, SHALL, or SHALL NOT requirements for the protocols it implements.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aka "minimum requirements"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rchincha this is actually the old content and unrelated to this PR. Will address this in #162

…-spec into HEAD

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes from commit 04ad275 LGTM .. not sure why the PR has 6 commits to fill in the overview section... guess it just needs to be rebased.

@jdolitsky
Copy link
Copy Markdown
Contributor Author

@mikebrow the updates are branched out like this:

reorg
 |
 --> mini-update-1
   |
   --> mini-update-2
     |
     --> mini-update-3

since each of these mini updates is built on top of one another, you're just seeing the commits from unmerged updates. Once #159 is merged, I can squash, or we can just worry about the aesthetics of this once we make a PR of reorg->master

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Jun 27, 2020

Once #159 is merged, I can squash, or we can just worry about the aesthetics of this once we make a PR of reorg->master

and on the twelfth day of christmas... :-) Of course, 159 does not match the spec so once we merge it the spec becomes a spec without a matching toc... ditto for the rest of the prs.. spec-new.md? or copy spec.md to spec-v.0.1.md Just thinking out-loud.

@jdolitsky
Copy link
Copy Markdown
Contributor Author

@mikebrow so very confused.. the idea is to operate on spec.md itself, and piecemeal the changes in. Instead of waiting until one PR is merged to open another, we simply opened several of them at once, built on top of one another, ordered by number (1, 2, 3 ...). The diffs are misleading, please see the PR descriptions. The TOC doesnt match the content since we havent gotten that far yet. Instead of deleting everything and starting fresh, it's important to see when/why things are being moved/deleted.

Maybe we can sync up early next week to discuss a strategy for this :)

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Jun 27, 2020

missed the new branch.. carry on :-) lol

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…nto mini-update-3

Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
@vbatts
Copy link
Copy Markdown
Member

vbatts commented Jun 29, 2020

LGTM

@vbatts vbatts merged commit 0206eb6 into opencontainers:reorg Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants