Skip to content

Improve licensing of tests source code#589

Merged
jdolitsky merged 1 commit intoopencontainers:mainfrom
Silvanoc:improve-licensing
Jan 20, 2026
Merged

Improve licensing of tests source code#589
jdolitsky merged 1 commit intoopencontainers:mainfrom
Silvanoc:improve-licensing

Conversation

@Silvanoc
Copy link
Copy Markdown
Contributor

@Silvanoc Silvanoc commented Dec 12, 2025

The source code files for the conformance tests don’t provide the typical Apache v2.0 licensing headers. The copyright holders are not explicitly listed either. It would make sense to have them for clearer licensing, simplifying contributions and reuse.

This PR adds the licensing headers provided by the Apache v2.0 license itself. It should also add the corresponding copyright holders.

This information should also help ensuring that the license information does not get lost, if someone comes to the idea of only copying the directory with the conformance tests.

Disclaimer: I am not a lawyer.

@jorydotcom
Copy link
Copy Markdown

Hi @Silvanoc thank you for your PR and the email to dev@!

There is some excellent guidance provided by an LF Legal team member and open source copyright expert that you might find useful: https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects

Would you be open to amending your PR to generalize the copyright notice?

@Silvanoc
Copy link
Copy Markdown
Contributor Author

Silvanoc commented Dec 12, 2025

There is some excellent guidance provided by an LF Legal team member and open source copyright expert that you might find useful: https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects

@jorydotcom thanks, I wasn't aware of it.

Would you be open to amending your PR to generalize the copyright notice?

Of course! That is exactly the intention! Though I would prefer to stick to providing the template in my commit and a project maintainer adds a commit with the desired copyright notice. Then I'd mark the PR as ready for review.

Ideally a list of contributors is also kept in which organizations can be entered. I've added a 2nd commit with that proposal? Reason for that? Because with the German working regulation that applies to my contributions, I am author, and my company is copyright holder.

Provide Apache Public License v2.0 provided template to all the tests
source code files. The copyright notice part needs to get replaced with
the correct copyright holders and years.

Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
@Silvanoc Silvanoc force-pushed the improve-licensing branch 2 times, most recently from a180e17 to af32c8c Compare January 20, 2026 16:33
@Silvanoc
Copy link
Copy Markdown
Contributor Author

@jorydotcom I've adapted the patch to the LF guidelines.

@Silvanoc Silvanoc marked this pull request as ready for review January 20, 2026 16:34
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky jdolitsky merged commit fa23d95 into opencontainers:main Jan 20, 2026
4 checks passed
@sudo-bmitch
Copy link
Copy Markdown
Contributor

Looking through the overall OCI organization, I'm seeing a variety of copyrights. Many are to the Linux Foundation. Some are to OCI Contributors. At least one is still licensed to the contributing company. Within distribution-spec, we are now inconsistent between the directories with "contributors to the Open Containers Distribution Specification" being added here.

I'm also unclear on whether we only need the copyright notice in Go code, or if files like the spec markdown files and yaml files defining github actions also need copyright notices. And many of the notices include a single year value, presumably the year the file was first added to the project. Occasionally the year is provided as a range.

It would be good for LF Legal to clarify if a single value should be used across the projects (at least for when code does not come from an external location), and what that value should be, both in file headers and the LICENSE file. @jorydotcom would you follow up on this?

@mikebrow
Copy link
Copy Markdown
Member

fair.. I suggest "adding" open containers distribution specification at the top of the files and not "removing" any of the existing copyrights that would be just below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants