Skip to content

Adjust the doc order of the content table#412

Merged
jonboulle merged 1 commit into
opencontainers:masterfrom
coolljt0725:doc_order
Oct 24, 2016
Merged

Adjust the doc order of the content table#412
jonboulle merged 1 commit into
opencontainers:masterfrom
coolljt0725:doc_order

Conversation

@coolljt0725
Copy link
Copy Markdown
Member

Signed-off-by: Lei Jitang leijitang@huawei.com

To make it more readable, make manifest.md and manifest-list.md above layer.md and config.md

Signed-off-by: Lei Jitang <leijitang@huawei.com>
@vbatts
Copy link
Copy Markdown
Member

vbatts commented Oct 24, 2016

LGTM

Approved with PullApprove

@jonboulle
Copy link
Copy Markdown
Contributor

jonboulle commented Oct 24, 2016

lgtm

Approved with PullApprove

@jonboulle jonboulle merged commit 720e2c1 into opencontainers:master Oct 24, 2016
@wking
Copy link
Copy Markdown
Contributor

wking commented Oct 24, 2016

On Sun, Oct 23, 2016 at 08:30:47PM -0700, Lei Jitang wrote:

To make it more readable, make manifest.md and manifest-list.md above layer.md and config.md You can view, comment on, or merge this pull request online at:

The previous order was intended to be bottom-up, so folks reading in order would never be reading about undefined dependencies. The new order is mixed. If the intention is to make it top-down, manifest-list should come first.

@jonboulle
Copy link
Copy Markdown
Contributor

Missed that. I guess it makes a bit of sense but I'd probably rather go for the top-down

@wking
Copy link
Copy Markdown
Contributor

wking commented Oct 24, 2016

On Mon, Oct 24, 2016 at 09:05:07AM -0700, Jonathan Boulle wrote:

I guess it makes a bit of sense but I'd probably rather go for the top-down

Would that be:

DOC_FILES := \
  README.md \
  code-of-conduct.md \
  project.md \
  media-types.md \
  manifest-list.md \
  manifest.md \
  layer.md \
  config.md \
  descriptor.md \
  image-layout.md \
  canonicalization.md

?

@coolljt0725 coolljt0725 deleted the doc_order branch October 25, 2016 01:13
@coolljt0725
Copy link
Copy Markdown
Member Author

@wking I though make manifest-list.md before manifest.md, but after reading the manifest.md, I think we could make manifest.md at first because at the beginning of manifest.md, it defines the manifest specification.

@wking
Copy link
Copy Markdown
Contributor

wking commented Oct 25, 2016

On Mon, Oct 24, 2016 at 06:18:22PM -0700, Lei Jitang wrote:

… I think we could make manifest.md at first because at the beginning of manifest.md, it defines the manifest specification.

There is similar context-setting at the start of manifest-list.md. I think manifest.md's current “three main goals” language is a bit stale though, since it seems to be introducing goals that lead to manifest lists (“fat manifest”) and configurations (“translatable to the OCI Runtime Specification”). Regardless of whether we use top-down or bottom-up ordering, I think manifest.md's lead-in should be trimmed to focus on the role of the manifest in the OCI image modeling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants