Skip to content

shfmt mounts.bats to pass make validate#2666

Merged
mrunalp merged 1 commit intoopencontainers:masterfrom
AkihiroSuda:shfmt-20201029
Oct 29, 2020
Merged

shfmt mounts.bats to pass make validate#2666
mrunalp merged 1 commit intoopencontainers:masterfrom
AkihiroSuda:shfmt-20201029

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Oct 29, 2020

CI on the master has been broken due to this.

https://travis-ci.org/github/opencontainers/runc/builds/739817745

Not sure why we couldn't catch this before merging it.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
Copy link
Copy Markdown
Contributor

@opencontainers/runc-maintainers can we please merge this one as otherwise a handful or recent PRs are failing?

@mrunalp mrunalp merged commit cf6c074 into opencontainers:master Oct 29, 2020
@kolyshkin
Copy link
Copy Markdown
Contributor

This happened because #2570 was not rebased on top of #2642 after the latter was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants