libcontainer/configs: improve unit tests#2660
Merged
AkihiroSuda merged 1 commit intoopencontainers:masterfrom Jan 27, 2021
Merged
libcontainer/configs: improve unit tests#2660AkihiroSuda merged 1 commit intoopencontainers:masterfrom
AkihiroSuda merged 1 commit intoopencontainers:masterfrom
Conversation
mauriciovasquezbernal
force-pushed
the
mauricio/fix_unittests
branch
from
1ef0fd3 to
7b00fff
Compare
Contributor
|
Can you please rebase this one since #2661 is merged? |
mauriciovasquezbernal
force-pushed
the
mauricio/fix_unittests
branch
from
7b00fff to
4432a5f
Compare
Contributor
Author
|
While studying these tests in more detail I found it was possible to improve them. |
Contributor
|
Need to be rebased again once #2666 is merged |
Contributor
@mauriciovasquezbernal please rebase |
mauriciovasquezbernal
force-pushed
the
mauricio/fix_unittests
branch
from
4432a5f to
1a768e3
Compare
Contributor
Author
|
@kolyshkin rebased! |
mauriciovasquezbernal
changed the title
kolyshkin
reviewed
Nov 9, 2020
mauriciovasquezbernal
force-pushed
the
mauricio/fix_unittests
branch
2 times, most recently
from
b11ae18 to
c3ae42d
Compare
Contributor
Author
|
@kolyshkin ping? |
kolyshkin
previously approved these changes
Jan 26, 2021
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM but needs to be rebased (again) to kick new CI
Test that CommandHook actually executes a new process with the given env variables, parameters and json state. This commit also solves an issue with the previous approach that was calling 'os.Exit(0)' failing to signal test failures. Signed-off-by: Mauricio Vásquez <mauricio@kinvolk.io>
mauriciovasquezbernal
force-pushed
the
mauricio/fix_unittests
branch
from
c3ae42d to
2be806d
Compare
Contributor
Author
|
@kolyshkin rebased and CI is green! :) |
AkihiroSuda
approved these changes
Jan 27, 2021
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM, but it might be better to have set -eu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that CommandHook actually executes a new process with the given env
variables, parameters and json state.
This commit also solves an issue with the previous approach that was calling
'os.Exit(0)' failing to signal test failures.
cc @alban
Fixes: #2765