ci: test with golang 1.16-rc1#2769
Merged
cyphar merged 2 commits intoopencontainers:masterfrom Feb 1, 2021
Merged
Conversation
kolyshkin
force-pushed
the
ci-go1.16
branch
4 times, most recently
from
e563934 to
3b1caa2
Compare
AkihiroSuda
previously approved these changes
Jan 27, 2021
go 1.16 has GO111MODULE=on by default, and since runtime-spec/schema does not come with go.mod, it complains: > runtime-spec/schema/validate.go:10:2: no required module provides package github.com/xeipuuv/gojsonschema: working directory is not part of a module Use GO111MODULE=auto as a workaround. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Courtesy of actions/setup-go#92 [v2: update from beta1 to rc1] Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
changed the title
AkihiroSuda
approved these changes
Jan 29, 2021
cyphar
approved these changes
Feb 1, 2021
Member
cyphar
left a comment
cyphar
left a comment
There was a problem hiding this comment.
LGTM, though it would be nice if we added 1.x and tip to our tests so we don't need to keep manually updating the GHA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using beta version of go as per actions/setup-go#92
[v2: move from beta1 to rc1]
Includes #2660 to fix #2675.