init: do not print environment variable value#3850
Merged
AkihiroSuda merged 1 commit intoopencontainers:mainfrom Apr 29, 2023
cyphar:env-nul-byte
Merged
init: do not print environment variable value#3850AkihiroSuda merged 1 commit intoopencontainers:mainfrom cyphar:env-nul-byte
AkihiroSuda merged 1 commit intoopencontainers:mainfrom
cyphar:env-nul-byte
Conversation
Member
Author
|
I'm still not sure what to do with environment variables that don't have an |
When given an environment variable that is invalid, it's not a good idea to output the contents in case they are supposed to be private (though such a container wouldn't start anyway so it seems unlikely there's a real way to use this to exfiltrate environment variables you didn't already know). Reported-by: Carl Henrik Lunde <chlunde@ifi.uio.no> Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
AkihiroSuda
approved these changes
Apr 29, 2023
AkihiroSuda
added
the
backport/1.1-todo
Contributor
|
1.1 backport: #3879 |
kolyshkin
added
backport/1.1-done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When given an environment variable that is invalid, it's not a good idea to output the contents in case they are supposed to be private (though such a container wouldn't start anyway so it seems unlikely there's a real way to use this to exfiltrate environment variables you didn't already know).
Reported-by: Carl Henrik Lunde chlunde@ifi.uio.no
Signed-off-by: Aleksa Sarai cyphar@cyphar.com
/cc @chlunde