[1.1] init: do not print environment variable value#3879
Merged
AkihiroSuda merged 1 commit intoopencontainers:release-1.1from May 24, 2023
Merged
[1.1] init: do not print environment variable value#3879AkihiroSuda merged 1 commit intoopencontainers:release-1.1from
AkihiroSuda merged 1 commit intoopencontainers:release-1.1from
Conversation
When given an environment variable that is invalid, it's not a good idea to output the contents in case they are supposed to be private (though such a container wouldn't start anyway so it seems unlikely there's a real way to use this to exfiltrate environment variables you didn't already know). Reported-by: Carl Henrik Lunde <chlunde@ifi.uio.no> Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> (cherry picked from commit 20e38fb) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
AkihiroSuda
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #3850 to release-1.1 branch. Original description follows.
When given an environment variable that is invalid, it's not a good idea to output the contents in case they are supposed to be private (though such a container wouldn't start anyway so it seems unlikely there's a real way to use this to exfiltrate environment variables you didn't already know).
Reported-by: Carl Henrik Lunde chlunde@ifi.uio.no
(cherry picked from commit 20e38fb)