Conversation
…le for one muscle
…imization into two_muscles_neumann
carme-hp
reviewed
May 12, 2025
Collaborator
carme-hp
left a comment
carme-hp
left a comment
There was a problem hiding this comment.
More points to discuss on person.
Collaborator
|
Please move all the updates of the bc to the update_neumann function, i.e., you should have and if-else there. This means you need to make the force accessible from the whole code and not only inside callback. Callback should only do the write to file. |
Collaborator
Author
|
I think this is now ready to merge. Can you review it @carme-hp? |
carme-hp
approved these changes
May 14, 2025
Collaborator
carme-hp
left a comment
carme-hp
left a comment
There was a problem hiding this comment.
Everything looks good I just made a small comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Issues that are addressed by this PR:
Features that have been added:
Add Neumann bc that couple the two muscles.
Additional information
Author's checklist