Skip to content

Conversation

@Agrendalath
Copy link
Member

@Agrendalath Agrendalath commented Apr 25, 2023

Description: This method will be renamed in the Redwood release.

Dependencies: This is required to support changes from openedx/openedx-platform#31492.

Testing instructions: See that the tests from openedx/openedx-platform#31492 are passing.

Reviewers:

  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings): n/a
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@openedx-webhooks
Copy link

Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

This method will be renamed in the Redwood release.
@Agrendalath Agrendalath force-pushed the agrendalath/rename_descriptor_to_block branch from f4be432 to 8141967 Compare April 26, 2023 13:18
@ormsbee ormsbee merged commit 4f2e83b into openedx:master Apr 26, 2023
@openedx-webhooks
Copy link

@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Agrendalath Agrendalath deleted the agrendalath/rename_descriptor_to_block branch April 26, 2023 13:44
@Agrendalath
Copy link
Member Author

@ormsbee, would you mind creating a release to push the new version to PyPI?

@ormsbee
Copy link

ormsbee commented Apr 26, 2023

@Agrendalath: Done (thanks to @kdmccormick, who clued me in to how we're using GitHub release now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants