[BD-13][BB-6927] Unify xblock naming descriptor

[pkulkark]

Description

Note: This PR depends on and includes the changes from #31475, which in turn depends on #31384. Use this link to see the actual diff.

This PR is the continuation of our previous effort to unify XBlock naming across the platform. This time, each descriptor occurrence reviewed and changed to block if it satisfied these criteria:

• It meant "XBlock".
• It was in *.py, *.rst, or *.md file.
• It didn't mean "Descriptor System" or "descriptor runtime".

Supporting Information

This PR should be merged along with:

• [BD-13][BB-6927] Rename descriptor to block xblock-lti-consumer#322 (closed, not needed)
• [BD-13][BB-6927] Rename descriptor to block mitodl/edx-sga#334 (optional)

Testing Instructions

Use the sandbox to perform general testing (courseware, course tabs, activation emails, course authoring, course exporting/importing, etc):

• LMS: https://pr31492.sandbox.opencraft.hosting/ (credentials: staff@example.com;edx)
• Studio: https://studio.pr31492.sandbox.opencraft.hosting/

[openedx-webhooks]

Thanks for the pull request, @pkulkark!

When this pull request is ready, tag your edX technical lead.

[e0d]

@Agrendalath is the plan to rebase this after #31472 is released or would there be value in doing so now?

I notice there are some failing unit tests, not sure if that will be addressed by the rebase.

[Agrendalath]

@e0d, both PRs change lots of files, so each rebase on #31472 is complex and time-consuming. We need to keep #31472 up-to-date because it is possible that changes introduced to edx-platform in the meantime (i.e. before we merge it) will be incompatible, despite not causing merge conflicts (example: 522c48c). Therefore, to reduce the maintenance, it makes more sense to rebase it after #31472 is merged.

I notice there are some failing unit tests, not sure if that will be addressed by the rebase.

Yes, these should be gone after the final rebase.

[Agrendalath]

@ormsbee, I plan to finish my last pass of review and fixes tomorrow. Most of the diffs are trivial, so to simplify things I would like to get your opinion on changes in the following files:

1. lms/djangoapps/courseware/block_render.py
2. lms/djangoapps/courseware/model_data.py
3. xmodule/modulestore/split_mongo/split.py

If you would also be able to review a small refactor in openedx/completion#231 (related to this PR), it would be perfect.

[Agrendalath]

👍

• I tested this: did regression checks locally
• I read through the code
• I checked for accessibility issues: n/a
• Includes documentation: n/a
• I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

[Agrendalath]

@e0d, this is good to go from my end. We'll need somebody to review a trivial change in openedx/completion#231 to support these changes. If you'd like, I can find a CC to do it next sprint.

Edit: I'll autosquash the commits before merging this.

[ormsbee]

@Agrendalath: I reviewed the changes in the files you mentioned, and that looks good to me. Also reviewed and merged completion API PR.

[Agrendalath]

Thank you, @ormsbee! If you could create a release from the tag for the completion PR, that would be all we need to merge this and close this project.

[ormsbee]

Weird, I did tag it, but I don't see it properly showing up on PyPI. I wonder if I messed that up somehow? I'll take a look.

[kdmccormick]

@ormsbee the release workflow triggers on publish so you will need to use the GH releases UI rather than just creating a tag. Fortunately, you can make a GH release from an existing tag.

[ormsbee]

Thanks @kdmccormick!

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the production environment.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the production environment.