feat: unify ModuleSystem and DescriptorSystem [BD-13] #31472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @kaustavb12! When this pull request is ready, tag your edX technical lead. |
kaustavb12
force-pushed
the
kaustav/unify_modulesystem_descriptorsystem
branch
2 times, most recently
from
4917eeb to
84beb2b
Compare
Agrendalath
changed the title
openedx-webhooks
added
blended
kaustavb12
force-pushed
the
kaustav/unify_modulesystem_descriptorsystem
branch
10 times, most recently
from
56519af to
ef00433
Compare
Agrendalath
reviewed
Feb 10, 2023
kaustavb12
force-pushed
the
kaustav/unify_modulesystem_descriptorsystem
branch
4 times, most recently
from
f90bb9d to
7b16070
Compare
Agrendalath
force-pushed
the
kaustav/unify_modulesystem_descriptorsystem
branch
from
7b16070 to
6b10606
Compare
Agrendalath
force-pushed
the
kaustav/unify_modulesystem_descriptorsystem
branch
3 times, most recently
from
06d148b to
d6eec2f
Compare
Agrendalath
approved these changes
Apr 3, 2023
Member
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
👍
- I tested this: did the regression testing of XBlocks, instructor tasks, etc.
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
Agrendalath
force-pushed
the
kaustav/unify_modulesystem_descriptorsystem
branch
from
c4d9e66 to
6b5f9ee
Compare
It was introduced in 159b707. We are removing this class. This also adds a missing test case.
This function was only used by tests. It was breaking tests from the `xmodule` package on the devstack because the dist.key of its entry_points is `open-edx`.
Agrendalath
force-pushed
the
kaustav/unify_modulesystem_descriptorsystem
branch
from
6b5f9ee to
c74f382
Compare
|
@kaustavb12 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
Agrendalath
added a commit
to open-craft/openedx-platform
that referenced
this pull request
May 2, 2023
After changes from openedx#31472, the user service of a "leaf" XBlock gets overridden with the one created for its parent (SequenceBlock). Therefore, the `requires_per_student_anonymous_id` is ignored in these XBlocks. The subsequent renders of an XBlock (e.g., when requesting the solution) use the student-specific IDs. This removes choosing the proper ID (course-specific or student-specific) from the runtime initialization. Instead, both IDs are passed to the user service. There are only two XBlocks that relied on the `requires_per_student_anonymous_id` - `ProblemBlock` and `HtmlBlock`. They now request the "deprecated" (student-specific) user ID directly from the user service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work in progress PR to unify ModuleSystem and DescriptorSystem
Supporting information
OpenCraft internal ticket BB-5967
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.