-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Badges XBlock Service #10580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badges XBlock Service #10580
Conversation
|
Thanks for the pull request, @Kelketek! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request. To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?number=10580&repo=edx%2Fedx-platform |
444f506 to
34a3519
Compare
34a3519 to
b59d6aa
Compare
8eb356c to
419f77e
Compare
|
@Kelketek This looks good apart from the one comment I added. |
|
Looking good now. 👍 once the build passes. The Python build was red with status "aborted" and no reported test failures – not sure what that means, so I just triggered a new run. |
419f77e to
1817d9b
Compare
00bd5a2 to
1f502ca
Compare
1817d9b to
0563546
Compare
e21a2ad to
6502241
Compare
0563546 to
1b618aa
Compare
e3aeb2b to
6343d7b
Compare
6343d7b to
0b431a8
Compare
|
@nedbat I've applied fixes for your notes. Is there anything else you need to see here or can I get a +1 from you on this part of the feature branch? |
|
👍 |
b5feea1 to
98f1635
Compare
866bc98 to
7ca49b4
Compare
98f1635 to
1b618aa
Compare
7ca49b4 to
a5e9a33
Compare
Description: Provides an XBlock service that exposes Badging functionality to XBlocks.
Jira: https://openedx.atlassian.net/browse/SOL-1363
Discussion/Spec: https://docs.google.com/document/d/1ob-leRHV97agPGw5ys9uASXrcsU8qf51bzYlKH3mBEM/edit?usp=sharing
Dependencies: https://github.com/edx/edx-platform/pull/10498
@smarnach Only the most recent commit is up for review here-- all the previous ones are from the dependency PR.