Skip to content

Conversation

@Kelketek
Copy link
Contributor

Description: Provides an XBlock service that exposes Badging functionality to XBlocks.
Jira: https://openedx.atlassian.net/browse/SOL-1363
Discussion/Spec: https://docs.google.com/document/d/1ob-leRHV97agPGw5ys9uASXrcsU8qf51bzYlKH3mBEM/edit?usp=sharing
Dependencies: https://github.com/edx/edx-platform/pull/10498

@smarnach Only the most recent commit is up for review here-- all the previous ones are from the dependency PR.

@openedx-webhooks
Copy link

Thanks for the pull request, @Kelketek! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?number=10580&repo=edx%2Fedx-platform

@Kelketek Kelketek force-pushed the badges-xblock-service branch from 444f506 to 34a3519 Compare November 10, 2015 23:18
@Kelketek Kelketek mentioned this pull request Nov 10, 2015
6 tasks
@Kelketek Kelketek force-pushed the badges-xblock-service branch from 34a3519 to b59d6aa Compare November 11, 2015 01:33
@smarnach
Copy link
Contributor

@Kelketek This looks good apart from the one comment I added.

@smarnach
Copy link
Contributor

Looking good now. 👍 once the build passes.

The Python build was red with status "aborted" and no reported test failures – not sure what that means, so I just triggered a new run.

@Kelketek Kelketek force-pushed the badges-xblock-service branch from 00bd5a2 to 1f502ca Compare November 16, 2015 16:14
@Kelketek Kelketek force-pushed the badges-xblock-service branch from e21a2ad to 6502241 Compare November 20, 2015 04:30
@Kelketek Kelketek force-pushed the badges-xblock-service branch 6 times, most recently from e3aeb2b to 6343d7b Compare November 25, 2015 22:45
@Kelketek Kelketek force-pushed the badges-xblock-service branch from 6343d7b to 0b431a8 Compare November 30, 2015 21:37
@Kelketek
Copy link
Contributor Author

Kelketek commented Dec 2, 2015

@nedbat I've applied fixes for your notes. Is there anything else you need to see here or can I get a +1 from you on this part of the feature branch?

@nedbat
Copy link
Contributor

nedbat commented Dec 3, 2015

👍

@Kelketek Kelketek force-pushed the badges-xblock-service branch from 7ca49b4 to a5e9a33 Compare December 3, 2015 18:22
@Kelketek Kelketek merged commit a5e9a33 into feature/badges-v2 Dec 3, 2015
@benpatterson benpatterson deleted the badges-xblock-service branch August 2, 2016 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants