Skip to content

Conversation

@dmitchell
Copy link
Contributor

@chrisndodge @cahrens Please review. This is blocking Chris.

@chrisndodge
Copy link
Contributor

I'm not a regex-guy so I'll defer to Christina (do you know more). But looks good to me.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be updated.

@cahrens
Copy link

cahrens commented Oct 17, 2013

👍 Once tests pass.

dmitchell added a commit that referenced this pull request Oct 17, 2013
Allow - ~ and . in course, branch, & block ids
@dmitchell dmitchell merged commit 2678f2a into master Oct 17, 2013
@dmitchell dmitchell deleted the dhm/bug-courseid branch October 17, 2013 18:21
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Nov 14, 2016
* Fix message on dashboard openedx#1386

* Fix bug openedx#1390

* Add ut case.
jamestait pushed a commit to open-craft/openedx-platform that referenced this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants