Student Dash: Disable "Email Settings" when course isn't authorized #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@flowerhack can you check out the tests since they're pretty similar to ones you wrote for instructor dash. |
lms/templates/dashboard.html
Outdated
Contributor
Author
There was a problem hiding this comment.
I'll be the first to admit I hate all this logic in the template, but the whole template is like this. Definitely the whole file could use a refactoring but at the moment this is the best I can do.
Contributor
|
Looks okay to me. 👍 |
Contributor
|
Yup, looks good to me |
Contributor
Author
|
I skipped the tests in common that failed in CMS only, and got the thumbs up from Will to merge. |
sarina
added a commit
that referenced
this pull request
Oct 17, 2013
…gs-with-auth Student Dash: Disable "Email Settings" when course isn't authorized
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Nov 14, 2016
* Fix message on dashboard openedx#1386 * Fix bug openedx#1390 * Add ut case.
jamestait
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this in PR https://github.com/edx/edx-platform/pull/1322 - whoops.
I also added some missing course auth tests around the legacy dashboard, and moved the student view tests into common/djangoapps/student/tests because that makes a ton more sense.