-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Updates problem-builder to v2.6.1 #13938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates problem-builder to v2.6.1 #13938
Conversation
|
Thanks for the pull request, @pomegranited! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request. To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?number=13938&repo=edx%2Fedx-platform |
|
jenkins run a11y |
|
jenkins run bokchoy |
|
@pomegranited, everything seems to be working, except that I can't seem to download CSV reports - get a 404. I went back and double-checked on my sandbox, and it's not working there either - I must have missed a step last night. Can you confirm that behavior/check for regression from the previous version? If it's not a regression, then I think we should still get this hotfix in and fix the CSV download at a later point. |
|
@haikuginger The issue with downloading report files is just a configuration issue with our OpenStack sandboxes, which will not be present in production. I've fixed it for this instance, and will raise a ticket to fix it permanently. |
|
Excellent; thanks! 👍
|
|
Thanks, @haikuginger ! @BenjiLee Are you willing to do a hotfix release for us? We'll also need some xblock-configuration changes, so I'll submit a DEVOPs ticket for that. |
|
@dianakhuang Are you willing to review this PR? It addresses the issues raised in TNL-5903.
|
|
The updated code looks good to me. 👍 |
|
@pomegranited, @dianakhuang will be running the hotfix for this since I have no context for this change. @dianakhuang If you need any release mastery support running the hotfix, let me know. |
|
Lovely, thank you @dianakhuang and @BenjiLee ! |
|
Wow ok, that got deployed really fast! Sorry I missed your hotfix release email, @BenjiLee , but thank you and @dianakhuang for getting that out! |
Updates problem-builder to v2.6.1.
Ref open-craft/problem-builder#128
JIRA tickets: Fixes the instructor_task import errors from TNL-5903.
Dependencies: https://github.com/edx/xblock-configuration/pull/9
Sandbox URL:
Partner information: DavidsonX
Testing instructions:
Features > Instructor ToolReviewers
Settings