Skip to content

Conversation

@singingwolfboy
Copy link
Contributor

#1785 without forums changes

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't go in without the corresponding later translation call

@singingwolfboy singingwolfboy mentioned this pull request Dec 6, 2013
@sarina
Copy link
Contributor

sarina commented Dec 9, 2013

LGTM 👍

@adampalay said in LMS chat that "there are also parts of the legacy dash that are untranslatable" - Adam I don't know what you mean by that, care to elaborate / look over this PR?

@adampalay
Copy link
Contributor

singingwolfboy added a commit that referenced this pull request Dec 9, 2013
@singingwolfboy singingwolfboy merged commit b784979 into master Dec 9, 2013
@singingwolfboy singingwolfboy deleted the man2life-i18n-no-forums branch December 9, 2013 19:28
cahrens pushed a commit that referenced this pull request Dec 11, 2013
Fallout from #1792.
cahrens pushed a commit that referenced this pull request Dec 11, 2013
Fallout from #1792.
@cahrens cahrens mentioned this pull request Dec 11, 2013
PYushchenko added a commit to smartdec/edx-platform that referenced this pull request Jun 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants