some i18n #1481
some i18n #1481
Conversation
common/templates/hinter_display.html
Outdated
There was a problem hiding this comment.
Can you pull the tags out of the string, or add a translator's note alerting the translator not to translate the tag?
|
@man2life , also, we don't want anything in common/templates or common/static to be dependent on django, so until we decide how we're going to go about translating the string there, don't worry about translating them. |
|
@man2life , any updates on this PR? |
|
@adampalay |
|
@man2life, just for common/templates/hinter_display.html-- the djangoapps in common will still have dependencies |
|
Something I've noticed in many of the common/templates & common/static files is comments around lines that will require i18n in the future - this would be a nice addition (since you've already identified them) to make short work of translating once we figure out a plan for these files. |
|
@man2life Looks like this pull request has conflicts, and needs to be rebased onto the latest master to resolve them. Do you know how to do that? |
|
Still this PR will need to be rebased to resolve conflicts! Sorry :( but can you do so, so that we can get moving on merging more open source PRs? Thanks 😄 |
The tab names are not being translated
|
Hi, is work on this pull request going to resume? If so please just put a comment in this PR (you can comment on the PR!) saying this is still active work. If I don't hear from you, however, we'll move to close this PR. You can re-open it when you resume work on this branch. Thanks! |
|
rebased and squashed |
Update course_navigation.html #os
Restful api for course advanced settings
|
Erp. Just found out you can't see that it can't be automatically merged. At any rate, from my end, it says that there are still conflicts. |
Changed unit identifier to be readonly, not disabled
There was a problem hiding this comment.
What is this file? Did you mean to add it to your pull request?
There was a problem hiding this comment.
Fixed. Strange i fixed it before.
fixes reset i18n of non-django template Some more i18n and fix in discussion
|
Hi, This PR can't be merged because it failed tests, and it needs a rebase. |
|
@andy-armstrong or @singingwolfboy could you guys please try to get this PR merged in? I don't know what else it might need. |
8 participants
Some i18n in different modules displayed to student.