Add handler_url usable by descriptors

[cpennington]

No description provided.

[cpennington]

@nedbat @flowerhack @sarina: Review?

[cpennington]

Oh, should have studio folk: @singingwolfboy or @andy-armstrong, want to comment?

[sarina]

There's a bunch of pylint violations & a bunch of untested lines in /x_module.py

[sarina]

Read up on this - it's super cool. Can you add a brief comment around this decorator explaining what it does to those unfamiliar with ddt?

[cpennington]

It seems a bit strange to comment this particular tool, out of all of the other tools from third parties that we use.

[sarina]

Eh fair, I guess my reasoning is most decorators are a lot more descriptive (ie @require_POST, @login_required) than @ddt is.

[andy-armstrong]

👍 I've got nothing to add to Sarina's comments.

[nedbat]

handler (str): would add type information. Maybe we don't need to here since views can only get strings?

[cpennington]

Note to self: add a class decorator that writes the boilerplate to satisy abc when you don't want to define all of the methods.

[nedbat]

This works:

from abc import ABCMeta, abstractmethod

class Abstract(object):
    __metaclass__ = ABCMeta

    def concrete(self):
        print("I am concrete")

    @abstractmethod
    def abstract1(self):
        raise NotImplementError("abstract1 isn't implemented")

    @abstractmethod
    def abstract2(self):
        raise NotImplementError("abstract2 isn't implemented")

def unabc(cls):
    """Write boilerplate to satisfy ABC requirements."""
    for ab_name in cls.__abstractmethods__:
        def shut_up_method(self, *args, **kwargs):
            raise NotImplementedError(ab_name + " isn't implemented!")
        setattr(cls, ab_name, shut_up_method)
    cls.__abstractmethods__ = ()
    return cls

@unabc
class ShutUp(Abstract):
    def abstract1(self):
        print("I am abstract1")

ab = ShutUp()
ab.concrete1()
ab.abstract1()
ab.abstract2()

[nedbat]

👍