-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Added matplotlib and pandas to sandbox requirements #1927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm not sure what ramifications new dependencies have on deploys. @cpennington or @e0d or @jarv can you weigh in here? |
|
This may be outside the scope of this PR, but I don't think we can continuously change the sandbox requirements to support the needs of any particular course; I don't think that's sustainable and undermines the sandboxing. I think we need a clean way to do the following things:
The first could be accomplished by doing something like establishing a convention for extending the platform. For example, there could be a .edX/ directory in the home of the running user with requirements/sandbox/requirements.txt or some such thing so that any deployer could extend the set of libraries available in the sandbox. The second would require a way of associating requirements with a course. When course were loaded they could either use the default sandbox virtualenv or, if the course had additional requirements, a new virtual env would be created for the course based on the default sandbox and extended. |
|
@e0d so what do you recommend we do with this PR? @carsongee how urgent is this need? |
|
Since it is such a simple change we can cherry pick it for the immediate need if you want to drop this. I agree on the sustainability for sure, and I could maybe direct my energy to solving the issue in the ansible plays instead of the platform directly if we want to make a deployment/configuration problem. I think longterm it would be very cool to fix it inside the platform on a per course basis as that could be a good way to handle per course xblocks down the road as well, but it is probably pretty involved to add that functionality. |
|
As a fun extra bit of info, this currently won't work on a box from scratch as freetype is required, but is installed by ORA and not edxapp. So this at the very least will require a PR to the config repo as well....Should I close this, and we can maybe add this to a longer term queue of what to do about this issue? |
|
@e0d @carsongee let's get some resolution around this PR, thanks. |
Adding requests so symmath works moved from post to base
|
I added requests and moved from post to base. We have a course using symmath (which was already here) on edx.org (12_340), and appears to rely on requests which is causing fails. I asked the course team to follow up with their PM about it, but since this came up here I thought I would add it in before we decide on this one (there may be other requirements missing for that too, but that is the one currently causing a stack trace). |
|
I just found out that the course we wanted to add matplotlib is planning to be on edx.org this Fall as an FYI: 6.341. |
|
It looks like 12_340x has worked around this in their courseware, so the need is not immediate. We will still eventually need more libraries so I think we should work towards a solution (even if this simple fix isn't it). I would also add that if we don't want to add all the dependencies for symmath to the sandbox requirements that we should at least remove symmath so people don't think it is available. |
|
I agree with that sentiment; we should either fully support it or not support it. I'll discuss with product. In the mean time I think we should close the PR. |
|
Works for me as long as this stays on the radar, maybe something in JIRA? |
…-message-search-course Mod message for search-course. openedx#1927
* MCKIN-22396 Fix samesite cookie issue for Scorm Shell login flow (openedx#1879) * Adds django-cookies-sameseite middleware and settings to set SameSite=None for all secure cookies. * Fix `SameSite` cookie issue for LTI Provider. EW-449 (cherry picked from commit 28479a2) * Fix tests, conflicts resolved Co-authored-by: Jillian Vogel <jill@opencraft.com> Co-authored-by: Zachary Trabookis <ztraboo@clemson.edu> * MCKIN-19584: add support for inline discussions translations (openedx#1863) * MCKIN-19584: add support for inline discussions translations (openedx#1830) * add support for inline discussions translations * mark js string for translation on discussions * ironwood fix * MCKIN-19840 EOC (End of course Journal) - None of the strings are translated in any language (openedx#1857) * MCKIN-19840 Add version bump for EOC 0.7.1 (openedx#1867) * MCKIN-23062 purge cohorts of deleted groups * MCKIN-23098 404 error on opening the module having EOC with no translations (openedx#1870) * MCKIN-23098 404 error on opening the module having EOC with no translations integrated * fix typo and chinese translation on discussions page (openedx#1875) * Fix mismatching versions for api integration * security fixes patch * MCKIN-23604 Match fork code with upstream (openedx#1880) * [MCKIN-21879] Remove foreign keys from deprecated `progress-edx-platform-extensions` (openedx#1874) * MCKIN-22507 Updated GW submission API to accept TA email id (openedx#1871) * MCKIN-22507 Updated GW submission API to accept TA email id * Fixed typo * MCKIN-22509 VB * [MCKIN-22507] Review version bump for xblock-group-project-v2 (openedx#1887) * MCKIN-22509 Added API to check/create anonymous user id (openedx#1882) * MCKIN-23249 Threw error if any of group has submissions (openedx#1884) * Added ignore condition for generated files * Release freeze (openedx#1895) * [MCKIN-21879] Remove foreign keys from deprecated `progress-edx-platform-extensions` (openedx#1874) * MCKIN-22507 Updated GW submission API to accept TA email id (openedx#1871) * MCKIN-22507 Updated GW submission API to accept TA email id * Fixed typo * MCKIN-22509 VB * [MCKIN-22507] Review version bump for xblock-group-project-v2 (openedx#1887) * MCKIN-22509 Added API to check/create anonymous user id (openedx#1882) * MCKIN-23249 Threw error if any of group has submissions (openedx#1884) * Added ignore condition for generated files Co-authored-by: Piotr Surowiec <piotr@opencraft.com> Co-authored-by: Nasir Hussain <nasirhjafri@gmail.com> Co-authored-by: Sohaib Aslam <sohaib.aslam@arbisoft.com> Co-authored-by: Shafqat Farhan <shafqat.farhan@arbisoft.com> * Revert "[MCKIN-21879] Remove foreign keys from deprecated `progress-edx-platform-extensions` (openedx#1874)" This reverts commit 5dad4f0. * Revert "[MCKIN-21879] Remove foreign keys from deprecated `progress-edx-platform-extensions` (openedx#1874)" This reverts commit 5dad4f0. * MCKIN-23061 Fix enlarged buttons on studio (openedx#1892) * Revert "Updated subsections grade percentage to start rounding" This reverts commit fde830b. * MCKIN-22514 problem builder verion bump * [MCKIN-21879] Remove foreign keys from deprecated `progress-edx-platform-extensions` * [BB-2765] Add `reverse_sql` to `database_fixups/0002` migration * MCKIN-24492 version bump api-integration (openedx#1898) * MCKIN-21527 Problem Builder (FTE, Assessment, MCQ, MRQ) - On opening these modules, none of the text is translated on notifications dropdown. (openedx#1889) * MCKIN-21918 Inline discussion japanese buttons (openedx#1891) Co-authored-by: murad-hubib <murad.habib@arbisoft.com> * bump xblock problem-builder version to 3.5.1 (openedx#1899) * MCKIN-24501 api-integration version bump (openedx#1903) * Security patch from aug 26 (openedx#1894) Co-authored-by: Ned Batchelder <ned@edx.org> * sustaining xss security fixes 3 (openedx#1893) Co-authored-by: Ali-D-Akbar <aliakbarit019@gmail.com> * Sustaining security fixes 4 & 5 (openedx#1901) Co-authored-by: Ali-D-Akbar <aliakbarit019@gmail.com> * MCKIN-24663 sorting alphanumeric list (openedx#1908) * MCKIN-24633 releasing problem builder v3.5.2 (openedx#1917) * MCKIN-24559 - Organization extensions VB (openedx#1905) Releasing `v2.0.6` * MCKIN-24565 - Organizations extensions VB (openedx#1907) Releasing `v2.0.7` * MCKIN-24511 Projects extension VB (openedx#1915) * Resolved conflits * Resloved conflicts * MCKIN-21919 Inline Discussion - The following strings are not translated in Korean Language (openedx#1906) * Resolved conflict * Resolved conflicts * MCKIN-24633 releasing problem builder v3.5.2 (openedx#1917) * MCKIN-25170 translation for review grade * MCKIN-24296 missing translations added (openedx#1926) * missing translations added (openedx#1927) * MCKIN-25091 fixed Discussion post Anonymously (openedx#1925) * VB for VR and eoc (openedx#1933) * MCKIN-25752 discussion and question posted translations (openedx#1934) * MCKIN-26123 Plateform Issues (openedx#1939) * MCKIN-26123 Plateform Issues (openedx#1940) * MCKIN-26123 Drag and Drop Version update (openedx#1942) * MCKIN-23104 version upgrade of EOC journal (openedx#1941) * MCKIN-26505 Version update of Problem Builder (openedx#1945) * MCKIN-26123 Drag&Drop Version Update (openedx#1947) * MCKIN-26589 Integrate translations of FIND DISCUSSIONS for main discussions page for all languages (openedx#1949) * [v1.54.0] complied mo files * compile js translations * Fix unit tests and compile msgs js issue. * Compile translations Co-authored-by: Moeez Zahid <moeezzahid1996@gmail.com> Co-authored-by: Jillian Vogel <jill@opencraft.com> Co-authored-by: Zachary Trabookis <ztraboo@clemson.edu> Co-authored-by: Saqib <msaqib52@gmail.com> Co-authored-by: Wasif ur Rehman <wasifarbisoft@users.noreply.github.com> Co-authored-by: Mudassir Hafeez <mudassir.hafeez@arbisoft.com> Co-authored-by: Shafqat Farhan <shafqat.farhan@arbisoft.com> Co-authored-by: ihtram <iulhaq@edx.org> Co-authored-by: Piotr Surowiec <piotr@opencraft.com> Co-authored-by: Nasir Hussain <nasirhjafri@gmail.com> Co-authored-by: Sohaib Aslam <sohaib.aslam@arbisoft.com> Co-authored-by: Agrendalath <piotr@surowiec.it> Co-authored-by: Mudassir Hafeez <41048311+mudassir-hafeez@users.noreply.github.com> Co-authored-by: murad-hubib <murad.habib@arbisoft.com> Co-authored-by: Ned Batchelder <ned@edx.org> Co-authored-by: Ali-D-Akbar <aliakbarit019@gmail.com> Co-authored-by: Naeem Ilyas <naeem-ilyas@live.com> Co-authored-by: Muhammad Usman <43761905+musmanmalik@users.noreply.github.com> Co-authored-by: Mudassir Hafeez <mudasir5761@gmail.com> Co-authored-by: ihtram <m.ihtram@arbisoft.com>
* MCKIN-22396 Fix samesite cookie issue for Scorm Shell login flow (openedx#1879) * Adds django-cookies-sameseite middleware and settings to set SameSite=None for all secure cookies. * Fix `SameSite` cookie issue for LTI Provider. EW-449 (cherry picked from commit 28479a2) * Fix tests, conflicts resolved Co-authored-by: Jillian Vogel <jill@opencraft.com> Co-authored-by: Zachary Trabookis <ztraboo@clemson.edu> * MCKIN-19584: add support for inline discussions translations (openedx#1863) * MCKIN-19584: add support for inline discussions translations (openedx#1830) * add support for inline discussions translations * mark js string for translation on discussions * ironwood fix * MCKIN-19840 EOC (End of course Journal) - None of the strings are translated in any language (openedx#1857) * MCKIN-19840 Add version bump for EOC 0.7.1 (openedx#1867) * MCKIN-23062 purge cohorts of deleted groups * MCKIN-23098 404 error on opening the module having EOC with no translations (openedx#1870) * MCKIN-23098 404 error on opening the module having EOC with no translations integrated * fix typo and chinese translation on discussions page (openedx#1875) * Fix mismatching versions for api integration * security fixes patch * MCKIN-23604 Match fork code with upstream (openedx#1880) * [MCKIN-21879] Remove foreign keys from deprecated `progress-edx-platform-extensions` (openedx#1874) * MCKIN-22507 Updated GW submission API to accept TA email id (openedx#1871) * MCKIN-22507 Updated GW submission API to accept TA email id * Fixed typo * MCKIN-22509 VB * [MCKIN-22507] Review version bump for xblock-group-project-v2 (openedx#1887) * MCKIN-22509 Added API to check/create anonymous user id (openedx#1882) * MCKIN-23249 Threw error if any of group has submissions (openedx#1884) * Added ignore condition for generated files * Release freeze (openedx#1895) * [MCKIN-21879] Remove foreign keys from deprecated `progress-edx-platform-extensions` (openedx#1874) * MCKIN-22507 Updated GW submission API to accept TA email id (openedx#1871) * MCKIN-22507 Updated GW submission API to accept TA email id * Fixed typo * MCKIN-22509 VB * [MCKIN-22507] Review version bump for xblock-group-project-v2 (openedx#1887) * MCKIN-22509 Added API to check/create anonymous user id (openedx#1882) * MCKIN-23249 Threw error if any of group has submissions (openedx#1884) * Added ignore condition for generated files Co-authored-by: Piotr Surowiec <piotr@opencraft.com> Co-authored-by: Nasir Hussain <nasirhjafri@gmail.com> Co-authored-by: Sohaib Aslam <sohaib.aslam@arbisoft.com> Co-authored-by: Shafqat Farhan <shafqat.farhan@arbisoft.com> * Revert "[MCKIN-21879] Remove foreign keys from deprecated `progress-edx-platform-extensions` (openedx#1874)" This reverts commit 5dad4f0. * Revert "[MCKIN-21879] Remove foreign keys from deprecated `progress-edx-platform-extensions` (openedx#1874)" This reverts commit 5dad4f0. * MCKIN-23061 Fix enlarged buttons on studio (openedx#1892) * Revert "Updated subsections grade percentage to start rounding" This reverts commit fde830b. * MCKIN-22514 problem builder verion bump * [MCKIN-21879] Remove foreign keys from deprecated `progress-edx-platform-extensions` * [BB-2765] Add `reverse_sql` to `database_fixups/0002` migration * MCKIN-24492 version bump api-integration (openedx#1898) * MCKIN-21527 Problem Builder (FTE, Assessment, MCQ, MRQ) - On opening these modules, none of the text is translated on notifications dropdown. (openedx#1889) * MCKIN-21918 Inline discussion japanese buttons (openedx#1891) Co-authored-by: murad-hubib <murad.habib@arbisoft.com> * bump xblock problem-builder version to 3.5.1 (openedx#1899) * MCKIN-24501 api-integration version bump (openedx#1903) * Security patch from aug 26 (openedx#1894) Co-authored-by: Ned Batchelder <ned@edx.org> * sustaining xss security fixes 3 (openedx#1893) Co-authored-by: Ali-D-Akbar <aliakbarit019@gmail.com> * Sustaining security fixes 4 & 5 (openedx#1901) Co-authored-by: Ali-D-Akbar <aliakbarit019@gmail.com> * MCKIN-24663 sorting alphanumeric list (openedx#1908) * MCKIN-24633 releasing problem builder v3.5.2 (openedx#1917) * MCKIN-24559 - Organization extensions VB (openedx#1905) Releasing `v2.0.6` * MCKIN-24565 - Organizations extensions VB (openedx#1907) Releasing `v2.0.7` * MCKIN-24511 Projects extension VB (openedx#1915) * Resolved conflits * Resloved conflicts * MCKIN-21919 Inline Discussion - The following strings are not translated in Korean Language (openedx#1906) * Resolved conflict * Resolved conflicts * MCKIN-24633 releasing problem builder v3.5.2 (openedx#1917) * MCKIN-25170 translation for review grade * MCKIN-24296 missing translations added (openedx#1926) * missing translations added (openedx#1927) * MCKIN-25091 fixed Discussion post Anonymously (openedx#1925) * VB for VR and eoc (openedx#1933) * MCKIN-25752 discussion and question posted translations (openedx#1934) * MCKIN-26123 Plateform Issues (openedx#1939) * MCKIN-26123 Plateform Issues (openedx#1940) * MCKIN-26123 Drag and Drop Version update (openedx#1942) * MCKIN-23104 version upgrade of EOC journal (openedx#1941) * MCKIN-26505 Version update of Problem Builder (openedx#1945) * MCKIN-26123 Drag&Drop Version Update (openedx#1947) * MCKIN-26589 Integrate translations of FIND DISCUSSIONS for main discussions page for all languages (openedx#1949) * [v1.54.0] complied mo files * MCKIN-24786 - api-integration version bump * MCKIN-26967 - EOC VB * MCKIN-23037 - Ooyala xblock version bump * MCKIN-27119 - Missing strings added * MCKIN-26468 - projects extensions VB (openedx#1951) Releasing `v3.0.4` * MCKIN-24382 Scorm VB (openedx#1966) * Scorm VB * MCKIN-26967 EOC VB * MCKIN-24385: bump xblock diagnostic feedback version to v0.4.0 (openedx#1971) * MCKIN-24468 McKA - Update Scorm xblock to Python 3.5 fix bug (openedx#1979) * MCKIN-24385 bump xblock-diagnosticfeedback version to v0.4.1 (openedx#1987) * MCKIN-26471 API integration VB (openedx#1995) * bump xblock scorm version to v3.2.1 (openedx#1996) * MCKIN-26850 EOC-journal version bump (openedx#2001) * MCKIN-24383 & 24384 VB for GP v2 and Adventure (openedx#1961) * MCKIN-24383 GW v2 version bump (openedx#2000) * vb gp (openedx#2002) * vb gp (openedx#2004) * MCKIN-28139 Pinned pyopenssl version to 18.0.0 * vb gp (openedx#2004) * MCKIN-28122 Traslations for all languages (openedx#2015) * MCKIN-28123 vb gp (openedx#2018) * Versions update. Co-authored-by: Moeez Zahid <moeezzahid1996@gmail.com> Co-authored-by: Jillian Vogel <jill@opencraft.com> Co-authored-by: Zachary Trabookis <ztraboo@clemson.edu> Co-authored-by: Saqib <msaqib52@gmail.com> Co-authored-by: Wasif ur Rehman <wasifarbisoft@users.noreply.github.com> Co-authored-by: Mudassir Hafeez <mudassir.hafeez@arbisoft.com> Co-authored-by: Shafqat Farhan <shafqat.farhan@arbisoft.com> Co-authored-by: ihtram <iulhaq@edx.org> Co-authored-by: Piotr Surowiec <piotr@opencraft.com> Co-authored-by: Nasir Hussain <nasirhjafri@gmail.com> Co-authored-by: Sohaib Aslam <sohaib.aslam@arbisoft.com> Co-authored-by: Agrendalath <piotr@surowiec.it> Co-authored-by: Mudassir Hafeez <41048311+mudassir-hafeez@users.noreply.github.com> Co-authored-by: murad-hubib <murad.habib@arbisoft.com> Co-authored-by: Ned Batchelder <ned@edx.org> Co-authored-by: Ali-D-Akbar <aliakbarit019@gmail.com> Co-authored-by: Naeem Ilyas <naeem-ilyas@live.com> Co-authored-by: Muhammad Usman <43761905+musmanmalik@users.noreply.github.com> Co-authored-by: Mudassir Hafeez <mudasir5761@gmail.com>
@sarina @jarvis
We have some residential courses including matplotlib and pandas libraries in their courseware. We would like to add these to the sandbox requirements.