Adds redirects for login pages and the registration page #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@flowerhack can you please review this? |
Contributor
There was a problem hiding this comment.
Can you add a comment here explaining what this does & when it should happen, so we don't accidentally later reorder things?
Applies at L242 and L525 as well.
Contributor
Author
There was a problem hiding this comment.
No problem, added for each case.
they go through the SSL login process in branding when that feature is enabled.
Contributor
|
100% quality 100% coverage geez! 👍 |
Contributor
|
Looks good to me! ⛵ |
flowerhack
pushed a commit
that referenced
this pull request
Dec 11, 2013
Adds redirects for login pages and the registration page
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents accidental registration and unnecessary account creation when SSL authentication is turned on in the platform that may occur when a user goes to a protected page, or directly to one of the signup/registration/login pages.
@sarina @ichuang @jbau