Check that SSL certificate is passed before redirecting to SSL authentication. #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 But someone else should also give you a thumbs up who knows more about auth than I do - @ichuang probably |
before redirecting to SSL authentication.
Contributor
|
LGTM |
Contributor
|
@carsongee two thumbs up means you're free to merge |
carsongee
added a commit
that referenced
this pull request
Dec 12, 2013
Check that SSL certificate is passed before redirecting to SSL authentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement to #1913 as a result of #1924. It checks to make sure that your certificate information is available before redirecting the user to the ssl login. As an important note, it converts the _ssl_get_cert_from_request to ssl_get_cert_from_request, and if merged before #1862 will require that PR to be rebased.
@sarina @ichuang @singingwolfboy