remove edx.org-specific content no longer used #2108
Conversation
|
please review @nedbat |
|
@sarina Review? |
|
@nedbat surely I will review this AM. |
There was a problem hiding this comment.
Why "Vision" and not "About"? I find this kind of weird
There was a problem hiding this comment.
The reason for About -> Vision was that the anchor text linking to the page actually said "Vision" so I was being consistent with the anchor text.
There was a problem hiding this comment.
Oh, weird. I got to this page by clicking "About" at the bottom of the page. Where is this paged linked to with "Vision" anchor text?
|
Maybe not in the scope of this PR but locally when I visit http://127.0.0.1:8000/courses and click on "Jobs" or "Press" (at the bottom of the page), the links do nothing. The other links ("About", "FAQ", "Contact", "Terms of Service...", "Privacy Policy") all work, except the "FAQ" link directs to |
|
Modulo my two comments, this looks good and works. |
|
Eek. We can access almost all of these pages via https://courses.edx.org/about etc. The links at the bottom of the page work properly (redirecting you to the appropriate drupal site page) -- should we get Ops to make some redirect rules or something to kill these pages completely, rather than having active site pages that someone could stumble upon read "This page left intentionally blank. It is not used by edx.org"...? |
|
Regarding your "Eek" I'm hoping we can just remove the urlconfs too in a followup PR. This PR is really just fixes for I18N extraction purposes. |
|
OK - either a PR removing the urlconfs should be made now, or a ticket should be made so we don't forget. But ideally this wouldn't go live in next week's push without urlconf changes. |
|
One odd possibility: on the page, use whatever tag gets us the proper link on the About link in the footer: "This page is not used by edX, try looking ." |
|
@nedbat putting that text on the page, though, I think goes against our goals of not having hard-coded edX references in our files. I like the text that's used here, just I would hope we could change the URLs so these aren't accessible. |
|
I talked wtih @nedbat and we're cool leaving this as an Easter egg to anyone bored enough to poke around at our site :) James I'm going to put a commit on your branch to remove the images that you removed references to, then I'll merge. |
|
+1 |
|
@jtauber I figured out why the JOBS & PRESS links weren't working and fixed those as well for completeness. There was a CMS acceptance test failure on the last build that I think is flakey (I was able to successfully finish the test manually) so re-running the build |
remove edx.org-specific content no longer used
* Add menu to ga_operation for ga_analyzer openedx#2039 (openedx#2088) * add role for old course viewer openedx#2062 (openedx#2087) * add role for old course viewer openedx#2062 * Change action for biz course by BetaTester role openedx#2062 * Construction of image server openedx#2025 (openedx#2106) * cherry-pick 8c8953f * Fix file upload in IE * Construction of image server openedx#2025 * add all keywords search in Student management openedx#2029 (openedx#2034) * Fix bug for before enrollment start in ga old course viewer openedx#2062 (openedx#2125) * fix. Construction of image server openedx#2025 (openedx#2117) * Modify message and css of enrollment for Course About openedx#2130 * Add a certificate list to user's profile page. openedx#2042 (openedx#2108) * Mod UT openedx#2130 * add PDF File Construction of image server openedx#2025 (openedx#2140) * add library option, and library links to the course. openedx#2001 (openedx#2124) * Invalid StudioPermissionsService object in API to show/save xblock settings in CMS. Randomized Content Block editor did not check Studio user's permissions * add library option, and library links to the course. openedx#2001 * fix. add all keywords search in Student management openedx#2029 (openedx#2034) (openedx#2157) * second fix. Construction of image server openedx#2025 (openedx#2158) * add library option, and library links to the course. openedx#2001 (openedx#2160) * third fix. Construction of image server openedx#2163 (openedx#2164) * Add filter by category for certificates on profile page openedx#2042 (openedx#2165) * Fix bug for add library option, and library links to the course. openedx#2162 openedx#2133 (openedx#2167) * Develop/dogwood/gacco201708 (openedx#2170) * Fixed bugs openedx#2039 (openedx#2112) * Fixed csv format openedx#2039 (openedx#2127) * Change to split download if there are many display items openedx#916 (openedx#2121) * Change to split download if there are many display items openedx#916 * Fix UT * Fix Review * Fix review2
These files are not used by edx.org since the introduction of the Drupal site. Nor was their content generally appropriate for Open edX installations.
The content is initially being removed to help simplify translation (there is no reason to translate the content that was there). A subsequent PR may remove these files all together but this will take more work.