Fix theme issues in Sass preprocessing #2131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm still getting errors with this branch: https://gist.github.com/wedaly/8356552 I'm testing this in devstack using the command: This runs using settings almost identical to the sandbox deploy. |
Contributor
|
with the last commit it's passing now :) |
Contributor
|
👍 |
Contributor
Author
|
@wedaly Yep, I made the PR before I actually tested it locally. As soon as I found that error, I fixed it in the PR. You were too fast for me! |
Contributor
|
looks good. |
wedaly
pushed a commit
that referenced
this pull request
Jan 10, 2014
Fix theme issues in Sass preprocessing
xitij2000
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Mar 17, 2021
…evelopment branch to development branch (openedx#2131) picked the required commits from backup-ironwood-development branch to development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I didn't catch this earlier.
Reviewers: @wedaly @feanil