css and html to support RTL #2138
Conversation
lms/static/sass/course-rtl.scss.mako
Outdated
There was a problem hiding this comment.
Due to #2131, this line should read if env['FEATURES'].get("USE_CUSTOM_THEME", False):
There was a problem hiding this comment.
This still needs to be changed.
|
is this PR going to be merged? what still needed, I'm interested in using this feature |
|
Looks like this pull request needs a rebase. Let me know if you have any trouble with this -- I'm happy to help walk you through the process. |
There was a problem hiding this comment.
Due to #2131, this line should read if env['FEATURES'].get("USE_CUSTOM_THEME", False):
|
@singingwolfboy thanks for your help and review. I rebased and pushed, waiting for the test results now. |
|
rebased! |
|
@abdoosh00 thanks for all your help on this, though I think the duping of files isn't ideal, so I have created a new PR (https://github.com/edx/edx-platform/pull/2682) that uses a different method that will be easier to maintain. Please leave comments and feedback on that PR or via email. (I will close this PR.) |
5 participants
No description provided.