Add apostrophe to lorem and fix single-quoted strings #2139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@andy-armstrong I know this is not the bullet-proof solution, but at least we can quickly fix these single-quotes. Review? |
Contributor
There was a problem hiding this comment.
is this enough to make sure that at least L' ## makes it into the string? Probably not for the shortest strings eg "Submit"
Contributor
|
Should we fix single-quoted strings in *.coffee and *.js files too? I'm curious how big this problem is. |
Contributor
|
👍 Looks like a reasonable short term fix. Do you know what's up with the test failure? |
nedbat
added a commit
that referenced
this pull request
Jan 13, 2014
Add apostrophe to lorem and fix single-quoted strings
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Sep 22, 2017
* Fix style. openedx#2139 * Fix po. openedx#2153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translated strings (think French) can have apostrophes in them. Translated strings are sometimes placed into single-quoted string literals, this will break French translations. Add an apostrophe to the dummy text to help flush out these problems. Also fix the dozen or so that I found with grep.