Skip to content

Conversation

@ovnicraft
Copy link
Contributor

Django toolbar released a stable version this needs updated.

base requirements install 1.0.1 but panels defined in envs are different.

@ovnicraft
Copy link
Contributor Author

@nedbat or @singingwolfboy can review it ?

@jarv
Copy link
Contributor

jarv commented Jan 16, 2014

👍 needs rebase

@jarv
Copy link
Contributor

jarv commented Jan 16, 2014

@ovnicraft can you rebase?

@nedbat
Copy link
Contributor

nedbat commented Jan 16, 2014

👍

@ovnicraft
Copy link
Contributor Author

@jarv rebased :-)

nedbat added a commit that referenced this pull request Jan 16, 2014
@nedbat nedbat merged commit 157f734 into openedx:master Jan 16, 2014
@cahrens
Copy link

cahrens commented Jan 17, 2014

@ovnicraft This change is not working when running CMS locally. It appears that there is a conflict between the debug toolbar and the way we use RequireJS in Studio. I have had to revert your change locally and force an install of the older version of the debug toolbar (0.9.4) in order to run.

@adampalay Is also having trouble.

FWIW, the devstack is working for folks. But I would like to see this change (and the follow-up PRs to fix issues) reverted unless someone has time to figure out what is going on with RequireJS.

@ovnicraft
Copy link
Contributor Author

@cahrens If you check code before my commit pip install toolbar 1.0.1 because its not defined version in base/requirement.txt.
You can check the panels here: http://django-debug-toolbar.readthedocs.org/en/1.0/configuration.html#debug-toolbar-panels

Can you help me with more info about problem how to reproduce it ?
I can try to figure out problem with RequireJS

Regards,

@cahrens
Copy link

cahrens commented Jan 17, 2014

Looks like it is a known issue with django debug toolbar and RequireJS. django-commons/django-debug-toolbar#506

@cahrens
Copy link

cahrens commented Jan 17, 2014

As far as reproducing, it is easy to see the problem if you are running CMS (Studio) locally (as opposed to the devstack). If you are running that way, rake cms, then go to a course in Studio and try doing anything (adding a new Section, opening a top-level menu, etc.). The require error prevents the JavaScript from loading properly.

@adampalay
Copy link
Contributor

I've just put in a PR to rollback this and the devstack commit: https://github.com/edx/edx-platform/pull/2218

jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants