-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Django toolbar update #2177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django toolbar update #2177
Conversation
|
@nedbat or @singingwolfboy can review it ? |
|
👍 needs rebase |
|
@ovnicraft can you rebase? |
|
👍 |
|
@jarv rebased :-) |
|
@ovnicraft This change is not working when running CMS locally. It appears that there is a conflict between the debug toolbar and the way we use RequireJS in Studio. I have had to revert your change locally and force an install of the older version of the debug toolbar (0.9.4) in order to run. @adampalay Is also having trouble. FWIW, the devstack is working for folks. But I would like to see this change (and the follow-up PRs to fix issues) reverted unless someone has time to figure out what is going on with RequireJS. |
|
@cahrens If you check code before my commit pip install toolbar 1.0.1 because its not defined version in base/requirement.txt. Can you help me with more info about problem how to reproduce it ? Regards, |
|
Looks like it is a known issue with django debug toolbar and RequireJS. django-commons/django-debug-toolbar#506 |
|
As far as reproducing, it is easy to see the problem if you are running CMS (Studio) locally (as opposed to the devstack). If you are running that way, rake cms, then go to a course in Studio and try doing anything (adding a new Section, opening a top-level menu, etc.). The require error prevents the JavaScript from loading properly. |
|
I've just put in a PR to rollback this and the devstack commit: https://github.com/edx/edx-platform/pull/2218 |
Merge from develop/dogwood/201709
Django toolbar released a stable version this needs updated.
base requirements install 1.0.1 but panels defined in envs are different.