Skip to content

Conversation

@wedaly
Copy link
Contributor

@wedaly wedaly commented Jan 16, 2014

#2177 Updated the Django debug toolbar and dev settings, but not devstack settings. This caused rake devstack to raise an exception:

django.core.exceptions.ImproperlyConfigured: Error importing debug panel debug_toolbar.panels.settings_vars: "No module named settings_vars"

This PR resolves the issue by updating devstack settings to match dev settings.

@flowerhack

@flowerhack
Copy link
Contributor

@wedaly
Copy link
Contributor Author

wedaly commented Jan 17, 2014

The test failures are a casualty of some git juggling last night for the release. Will merge once I get a clean build.

@yarko
Copy link
Contributor

yarko commented Jan 17, 2014

#2171 only updated [cms,lms]/envs/dev.py - and even there it left a problem - a commented out ProfilingDebugPanel (the new debug toolbar panel name is now ProfilingPanel - see http://django-debug-toolbar.readthedocs.org/en/1.0/panels.html;

This - #2208 - caught a few more files - [cms,lms]/envs/devstack.py - but also left the problem lurking in the comments by not updating the ProfilingPanel name (so that still needs to happen).

The files you still missed are:

  • lms/envs/content.py
  • cms/envs/dev_dbperf.py
  • lms/envs/devplus.py

You can find my patch file from the head as of last night here: https://gist.github.com/yarko/8473409

@wedaly
Copy link
Contributor Author

wedaly commented Jan 17, 2014

@yarko Thanks for pointing that out. I have an immediate need to get devstack fixed, so I'm going to merge this as-is. Could you please open a separate PR for the changes in your patch?

wedaly pushed a commit that referenced this pull request Jan 17, 2014
Updated settings for devstack django debug toolbar
@wedaly wedaly merged commit 0cba92a into master Jan 17, 2014
@wedaly wedaly deleted the will/fix-devstack-django-toolbar branch January 17, 2014 14:06
@cahrens
Copy link

cahrens commented Jan 17, 2014

@yarko I can't run Studio now locally (it works on the devstack), and I think it is related to the django debug toolbar change. Are you aware of the problem? Do you have a proposed change yet?

jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Oct 19, 2017
* fix add note to Zendesk help openedx#2194 (openedx#2202)

* fix add library option, and library links to the course. openedx#2181 (openedx#2205)

* second fix. add library option, and library links to the course. openedx#2210 (openedx#2211)

* third fix. add library option, and library links to the course. openedx#2213 (openedx#2214)

* Add the validation of the due date before 1900 openedx#2188 (openedx#2208)

* Fix bug for biz playback page title openedx#2195 (openedx#2203)

* fix test case. add library option, and library links to the course. openedx#2213 (openedx#2220)

* Add note to page of Password reset confirm. openedx#2216 (openedx#2217)

* Add login code to Playback Status page when the contract using login code openedx#2193 (openedx#2209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants