enable tests depending on assert is_css_present(css_selector) #2214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wedaly Do you think this is sufficient? |
Contributor
|
@zubair-arbi The changes look reasonable, but it's hard to tell if this will fix the underlying problem without running them repeatedly. I'd recommend running just the failing tests multiple times using this Jenkins job: https://jenkins.testeng.edx.org/job/edx-acceptance-manual-pr/ If they pass consistently, then 👍 |
Contributor
Author
|
@wedaly I ran the failing tests at least 5 times (jenkins) each for both course-team and static-pages and all passed successfully every time. |
Contributor
|
👍 |
|
👍 Thanks Zubair-- go ahead and merge. |
zubair-arbi
added a commit
that referenced
this pull request
Jan 21, 2014
…estest enable tests depending on assert is_css_present(css_selector)
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Oct 19, 2017
* fix add note to Zendesk help openedx#2194 (openedx#2202) * fix add library option, and library links to the course. openedx#2181 (openedx#2205) * second fix. add library option, and library links to the course. openedx#2210 (openedx#2211) * third fix. add library option, and library links to the course. openedx#2213 (openedx#2214) * Add the validation of the due date before 1900 openedx#2188 (openedx#2208) * Fix bug for biz playback page title openedx#2195 (openedx#2203) * fix test case. add library option, and library links to the course. openedx#2213 (openedx#2220) * Add note to page of Password reset confirm. openedx#2216 (openedx#2217) * Add login code to Playback Status page when the contract using login code openedx#2193 (openedx#2209)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STUD-1183
@cahrens @adampalay @waheedahmed @symbolist
Increase timeout for function "is_css_present" from 10 to 30.