Skip to content

Conversation

@andy-armstrong
Copy link
Contributor

This implements STUD-1192, which provides the service needed for the new move modal (STUD-1054).

@cahrens @dmitchell Please review.

@cahrens
Copy link

cahrens commented Jan 21, 2014

@andy-armstrong Check the coverage report-- it looks like part of your unit test may not be executed (it could also be a false positive, as there seem to be some bugs in diffcover).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI-- this can be simplified to self.course_locator.url_reverse('course'). No need to change, just wanted to let you know.

@andy-armstrong
Copy link
Contributor Author

@cahrens @dmitchell Here's a version with unit tests that actually test stuff.

@andy-armstrong
Copy link
Contributor Author

@cahrens @dmitchell Here's a squashed version with Christina's suggestions applied.

@cahrens
Copy link

cahrens commented Jan 22, 2014

👍

1 similar comment
@dmitchell
Copy link
Contributor

👍

andy-armstrong added a commit that referenced this pull request Jan 22, 2014
Implement a course outline REST API
@andy-armstrong andy-armstrong merged commit de548fb into master Jan 22, 2014
@andy-armstrong andy-armstrong deleted the andya/move-service branch January 22, 2014 21:10
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Oct 19, 2017
* fix add note to Zendesk help openedx#2194 (openedx#2202)

* fix add library option, and library links to the course. openedx#2181 (openedx#2205)

* second fix. add library option, and library links to the course. openedx#2210 (openedx#2211)

* third fix. add library option, and library links to the course. openedx#2213 (openedx#2214)

* Add the validation of the due date before 1900 openedx#2188 (openedx#2208)

* Fix bug for biz playback page title openedx#2195 (openedx#2203)

* fix test case. add library option, and library links to the course. openedx#2213 (openedx#2220)

* Add note to page of Password reset confirm. openedx#2216 (openedx#2217)

* Add login code to Playback Status page when the contract using login code openedx#2193 (openedx#2209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants