Detached categories don't access control on date #2209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Squash/rebase this? |
Contributor
|
👍 |
Contributor
Author
|
@cpennington @nedbat Refactored to use XBlock tags. Cleaned up commits, fixed broken orphan fns, and removed accidentally included settings. |
Contributor
There was a problem hiding this comment.
New code should use runtime instead of system (throughout).
Contributor
|
👍 |
Contributor
Author
|
@nedbat I believe I fixed all the things you pointed out (nice job btw) |
Contributor
There was a problem hiding this comment.
Another "system" to change...
Contributor
Author
There was a problem hiding this comment.
Hmmm, I believe it's impossible for an xblock not to have runtime defined, so, I'm getting rid of the if. Let me know if that's wrong.
Contributor
|
One more thing to fix, then 👍 |
dmitchell
added a commit
that referenced
this pull request
Jan 19, 2014
Detached categories don't access control on date
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Oct 19, 2017
* fix add note to Zendesk help openedx#2194 (openedx#2202) * fix add library option, and library links to the course. openedx#2181 (openedx#2205) * second fix. add library option, and library links to the course. openedx#2210 (openedx#2211) * third fix. add library option, and library links to the course. openedx#2213 (openedx#2214) * Add the validation of the due date before 1900 openedx#2188 (openedx#2208) * Fix bug for biz playback page title openedx#2195 (openedx#2203) * fix test case. add library option, and library links to the course. openedx#2213 (openedx#2220) * Add note to page of Password reset confirm. openedx#2216 (openedx#2217) * Add login code to Playback Status page when the contract using login code openedx#2193 (openedx#2209)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired programmed w/ @singingwolfboy as a better way to fix the lms can't access pages which don't really have start dates (about, static_tab, and course_info) rather than hardcoding universal time 0 as the start date.
@cpennington or @nedbat please approve
@adampalay please review