Rename values in SiteConfiguration/History (1/3) (retry) #23144
Conversation
This reverts commit 84de6bc which reverts commit cebeab4 which implements the first stage of the `values` column rename in SiteConfiguration. However, I included a small change: This time, we set a default value on the new `site_values` column so that the ORM will happily deserialize the JSONField without throwing a JSONDecodeError.
pwnage101
changed the title
|
Your PR has finished running tests. There were no failures. |
pwnage101
requested review from
HassanJaveed84,
bmedx,
brianhw,
doctoryes,
estute and
hunytalk
| # The actual default value is determined by calling the given callable. | ||
| # Therefore, the default here is just {}, since that is the result of | ||
| # calling `dict`. | ||
| default=dict, |
There was a problem hiding this comment.
This line is the only change since #22692.
bmedx
left a comment
bmedx
left a comment
There was a problem hiding this comment.
I didn't follow the original revert, but if it was just the deserialization I agree this should fix it. I assume the migration was reverted as well?
|
@bmedx Yes - the migration was reverted by me. |
pwnage101
deleted the
pwnage101/rename_site_configuration_siteconfiguration_values_1.1
branch
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
|
EdX Release Notice: This PR has been deployed to the production environment. |
This reverts commit 84de6bc
which reverts commit cebeab4
which implements the first stage of the
valuescolumn rename inSiteConfiguration. However, I included a small change:
This time, we set a default value on the new
site_valuescolumn sothat the ORM will happily deserialize the JSONField without throwing a
JSONDecodeError.
DENG-18