Skip to content

Conversation

@gabor-boros
Copy link
Contributor

@gabor-boros gabor-boros commented Oct 25, 2021

This is the backport of https://github.com/edx/edx-platform/pull/27028.


This pull requests backport a feature to include CCX course IDs in the generated course filenames used for downloading reports, etc.

The suffix appended to the generated filename prefix is following the <separator>_ccx_<ccx id> pattern, to ensure unique filename generation per ccx - previously all CCX courses were downloaded with the same name.

Dependencies: None

Screenshots:
Screenshot 2021-03-16 at 16 22 12

Sandbox URL: TBD

Merge deadline: None

Testing instructions:

  1. Navigate to https://pr29101.sandbox.opencraft.hosting
  2. Login as staff
  3. Navigate to https://pr29101.sandbox.opencraft.hosting/courses/ccx-v1:edX+DemoX+Demo_Course+ccx@1/instructor#view-data_download
  4. Click "Download profile information as a CSV" button
  5. Check that the file name contains CCX

@openedx-webhooks
Copy link

Thanks for the pull request, @gabor-boros! I've created OSPR-6166 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Oct 25, 2021
@gabor-boros gabor-boros changed the title feat: add CCX ID to generated filename prefixes (#27028) [SE-4631] add CCX ID to generated filename prefixes (#27028) Oct 25, 2021
@natabene
Copy link
Contributor

@gabor-boros Thank you for the contribution. Please let me know once this is ready.

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Nov 1, 2021
Copy link
Contributor

@pkulkark pkulkark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • I tested this: verified that the required ccx prefix is added to the filename as described in the testing instructions
  • I read through the code
  • I checked for accessibility N/A
  • Incudes documentation N/A

@gabor-boros
Copy link
Contributor Author

@natabene this is ready for edX review. Thank you!

@BbrSofiane
Copy link
Contributor

Looks good to me.

@edx-community-bot merge.

@edx-community-bot edx-community-bot merged commit 9d349a8 into openedx:open-release/lilac.master Nov 8, 2021
@openedx-webhooks openedx-webhooks added merged and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. awaiting prioritization labels Nov 8, 2021
@openedx-webhooks
Copy link

@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the gabor/cherry-pick-ccx-filename-lilac branch January 12, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants