revert: temp: let XBlock API users optionally use LabXchange block types #31315
Conversation
|
Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
when fetching block metadata and rendering blocks while maintaining the original usage IDs/OLX. Reverts ef8f841
pomegranited
force-pushed
the
jill/remove-labxchange
branch
from
c2b8f31 to
5370185
Compare
|
@toxinu This OSPR is ready for your review (at last 😄 ). FYI @jristau1984 |
|
I have checked the changes, looks good to be merged @pomegranited 👍 |
|
Hi @pomegranited! Is this all set to merge? |
|
Hi @mphilbrick211 yes, this is ready to merge, but needs a 2nd review from a core contributor or edX/2U. I've looped you in on the email thread, thank you! |
bradenmacdonald
left a comment
bradenmacdonald
left a comment
There was a problem hiding this comment.
Thank you for cleaning this up. The changes look good to me. 👍
- I did not manually test this (relying on earlier review)
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a but the docstrings have been improved via this pair of PRs.
|
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
Thank you @bradenmacdonald ! |
fix: fix 500 error when fetching course run (#31518) chore: bumping enterprise package version to 3.60.10 feat: ping 2u-tnl for changes to student model student model changes should notify 2u-tnl team, to trigger a SOX compliance oriented review of the changes. feat: point to newly refacto revert: temp: let XBlock API users optionally use LabXchange block types (#31315) when fetching block metadata and rendering blocks while maintaining the original usage IDs/OLX. Reverts ef8f841 chore: Updating Python Requirements build: Adding constraint to avoid multiple major upgrades. build: Adding constraint to avoid multiple major upgrades. chore: Updating Python Requirements (#31525) build: Adding constraint to avoid multiple major upgrades. chore: Updating Python Requirements (#31526) build: Adding constraint to avoid multiple major upgrades. build: Adding constraint to avoid multiple major upgrades. feat: release edx-enterprise 3.60.11 (#31528) build: Adding constraint to avoid multiple major upgrades. chore: Updating Python Requirements (#31533) fix: fix the tests in test_register file (#31523) chore: Updating Python Requirements (#31534) fix: fixing upgrades. fixing: fixing upgrades. chore: Updating Python Requirements (#31535) fix: fixing upgrades chore: Updating Python Requirements (#31536) fix: fixing upgrades chore: Updating Python Requirements (#31538) fix: fixing upgrades chore: Updating Python Requirements (#31539)
6 participants
Description
Reverts ef8f841, which added Labxchange-specific code allowing LabXchange XBlocks to be used when loading and rendering non-lx blocks.
This code is no longer required, as LabXchange are storing OLX in their own database, and not using Open edX for rendering anymore. Some Content Libraries (Blockstore) calls are still being made to fetch asset files, but these do not require loading blocks, and so the LX-specific code here (and dependencies in https://github.com/edx/edx-internal/pull/7420) can be removed from edx.org without adversely impacting LabXchange.org.
This change impacts LabXchange only, and should not have any effect on other users of Open edX.
Supporting information
See #29517
Testing instructions
CI should be sufficient to ensure this change is safe for Open edX.
LabXchange testing will take place on (internal) https://gitlab.com/opencraft/client/LabXchange/labxchange-dev/-/merge_requests/1862.
Deadline
None