fix: fix the tests in test_register file#31523
Merged
attiyaIshaque merged 1 commit intomasterfrom Jan 13, 2023
Merged
Conversation
attiyaIshaque
force-pushed
the
attiya/VAN-900-fix-tests
branch
from
71ff414 to
08b3e64
Compare
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
awais786
pushed a commit
that referenced
this pull request
Jan 13, 2023
fix: fix 500 error when fetching course run (#31518) chore: bumping enterprise package version to 3.60.10 feat: ping 2u-tnl for changes to student model student model changes should notify 2u-tnl team, to trigger a SOX compliance oriented review of the changes. feat: point to newly refacto revert: temp: let XBlock API users optionally use LabXchange block types (#31315) when fetching block metadata and rendering blocks while maintaining the original usage IDs/OLX. Reverts ef8f841 chore: Updating Python Requirements build: Adding constraint to avoid multiple major upgrades. build: Adding constraint to avoid multiple major upgrades. chore: Updating Python Requirements (#31525) build: Adding constraint to avoid multiple major upgrades. chore: Updating Python Requirements (#31526) build: Adding constraint to avoid multiple major upgrades. build: Adding constraint to avoid multiple major upgrades. feat: release edx-enterprise 3.60.11 (#31528) build: Adding constraint to avoid multiple major upgrades. chore: Updating Python Requirements (#31533) fix: fix the tests in test_register file (#31523) chore: Updating Python Requirements (#31534) fix: fixing upgrades. fixing: fixing upgrades. chore: Updating Python Requirements (#31535) fix: fixing upgrades chore: Updating Python Requirements (#31536) fix: fixing upgrades chore: Updating Python Requirements (#31538) fix: fixing upgrades chore: Updating Python Requirements (#31539)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some tests in
user_authn/views/tests/test_register.pyfail when run in a particular order locally on devstack because when we run in specific order with the feature flagENABLE_COPPA_COMPLIANCEisTrueit will remove theself.EXTRA_FIELDS.remove('year_of_birth')so the EXTRA_FIELDS is define globally. When we run the tests in specific orderyear_of_birthdidn't find and the next tests will be failed.VAN-900
Testing instructions
you can test it by running this command.
pytest -p 'no:randomly' openedx/core/djangoapps/user_authn/views/tests/test_register.py::RegistrationViewTestV2::test_year_of_birth_field_with_feature_flag openedx/core/djangoapps/user_authn/views/tests/test_register.py::RegistrationViewTestV2::test_register_form_year_of_birth openedx/core/djangoapps/user_authn/views/tests/test_register.py::RegistrationViewTestV2::test_field_order_override openedx/core/djangoapps/user_authn/views/tests/test_register.py::RegistrationViewTestV2::test_field_order openedx/core/djangoapps/user_authn/views/tests/test_register.py::RegistrationViewTestV2::test_field_order_invalid_overrideIt will fail on
MASTER BRANCH.