Skip to content

Conversation

@UvgenGen
Copy link
Contributor

@UvgenGen UvgenGen commented Dec 9, 2022

Description

Should be merged after first part: #31422
Second part of preparing tests for Remove support for children in Old Mongo task (#31134).

  • Fixed problem with .get_children() in tests for split modulestore.
    Problem: If we create some CourseItem with some parent, we must get the updated parent item before using that parent item.
  • Updated CourseOverview Signals Tests for split modulestore. (problem with timezone for datetime field, get_children, )
  • Updated test_assets.py for split modulestore. (assets paths/urls)

Useful information to include:
First part: #31422
Remove support for children in Old Mongo PR: #31134
openedx/public-engineering#80

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 9, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@UvgenGen UvgenGen force-pushed the sagirov/EDXOLDMNG-192-part2 branch from 702f343 to 6f558a6 Compare December 9, 2022 15:22
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Dec 16, 2022
@UvgenGen UvgenGen force-pushed the sagirov/EDXOLDMNG-192-part2 branch 2 times, most recently from 0469786 to ab76c7a Compare December 21, 2022 11:57
@UvgenGen UvgenGen force-pushed the sagirov/EDXOLDMNG-192-part2 branch from ab76c7a to 043a2ff Compare December 21, 2022 17:51
@mphilbrick211
Copy link

Hi @UvgenGen - is this ready for review?

@UvgenGen
Copy link
Contributor Author

Hi @mphilbrick211. Yes, it's ready for review

@mphilbrick211
Copy link

Flagging this for you @ormsbee!

@ormsbee
Copy link
Contributor

ormsbee commented Jan 17, 2023

I'll merge this later today

@ormsbee ormsbee merged commit 1c664bc into openedx:master Jan 17, 2023
@openedx-webhooks
Copy link

@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants