Skip to content

Conversation

@UvgenGen
Copy link
Contributor

Description

Should be merged after: #31466
Fourth part of preparing tests for Remove support for children in Old Mongo task (#31134).

  • updated test_import.py and test_course_index.py for split modulestore
  • fixed 400 error for cms old_style assets

Useful information to include:
First part: #31422
Second part: #31427
Third part: #31466
Remove support for children in Old Mongo PR: #31134
openedx/public-engineering#80

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 28, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@UvgenGen UvgenGen force-pushed the sagirov/EDXOLDMNG-192-part4 branch 3 times, most recently from b24caa0 to 6467462 Compare December 28, 2022 17:31
@mphilbrick211
Copy link

Hi @UvgenGen -is this ready for review?

@UvgenGen
Copy link
Contributor Author

@mphilbrick211 yes, this is ready for review. I'll rebased it today.

@UvgenGen UvgenGen force-pushed the sagirov/EDXOLDMNG-192-part4 branch from 6467462 to c839580 Compare January 24, 2023 16:59
@mphilbrick211 mphilbrick211 requested a review from ormsbee January 24, 2023 18:22
@mphilbrick211
Copy link

Flagging this for you @ormsbee!

Copy link
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this on Monday morning.

@ormsbee ormsbee merged commit 7a21c22 into openedx:master Jan 30, 2023
@openedx-webhooks
Copy link

@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants