Skip to content

[sumac] fix: keep library collection card component count in sync (#35734) #35886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bradenmacdonald merged 3 commits into from
Nov 21, 2024
Merged

[sumac] fix: keep library collection card component count in sync (#35734) #35886

bradenmacdonald merged 3 commits into from
Nov 21, 2024

Conversation

@ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Nov 19, 2024 •
edited
Loading

Fixed component counter synchronization and adds a published > num_counts field in collections in the search index.

Cherry-picked from these commits:

Backport of #35734

@ChrisChV
fix: keep library collection card component count in sync (openedx#35734
38c5290 
)

Fixed component counter synchronization in these cases:

* When deleting a component inside a collection.
* With the library published, when adding a new component in a collection and reverting library changes.
* With the library published, when deleting a component inside a collection and reverting library changes.

Also adds a published > num_counts field in collections in the search index.
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 19, 2024

Thanks for the pull request, @ChrisChV!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 19, 2024
@ChrisChV
Copy link
Contributor Author

ChrisChV commented Nov 19, 2024

CC @farhaanbukhsh

@bradenmacdonald bradenmacdonald mentioned this pull request Nov 19, 2024
Merged
@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Nov 19, 2024

Hmm, seems like we have several different issues caused by bumping the openedx-learning version without backporting other changes. I was kind of worried this would happen. Though I'm not really sure why common_constraints.txt is changing. Is that happening on sumac.master too?

CC @ormsbee

@ChrisChV
Copy link
Contributor Author

ChrisChV commented Nov 20, 2024 •
edited
Loading

Though I'm not really sure why common_constraints.txt is changing. Is that happening on sumac.master too?

Yes, common_constraints.txt changes when compiling the requirements. The solution would be to backport this common_constraints.txt change or a backport of this 040ff12

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 21, 2024
@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Nov 21, 2024

Oh I see now that the only changes are to commented out lines, so it's totally fine to just include those common_constraints.txt changes in this PR. I'm not sure the best way to solve the other static analysis issue though; I suspect you'll also need to bring in d197077

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Nov 21, 2024

Looks good. Is there an easy way for me to test this? (without interrupting my master devstack)

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Nov 21, 2024

OK, I got my Sumac devstack working and tested this out. Nice work :)

bradenmacdonald
bradenmacdonald approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: on a Sumac tutor devstack, following the instructions from #35734
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@bradenmacdonald bradenmacdonald merged commit 2c57520 into openedx:open-release/sumac.master Nov 21, 2024
@bradenmacdonald bradenmacdonald deleted the chris/sumac/FAL-3921-remove-unpublished-collections branch November 21, 2024 22:59
@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Nov 21, 2024

FYI on this backport, @farhaanbukhsh

@feanil feanil mentioned this pull request Dec 10, 2024
Closed
Waleed-Mujahid pushed a commit to edly-io/edx-platform that referenced this pull request Aug 4, 2025
@ChrisChV @Ian2012 @Waleed-Mujahid
[sumac] fix: keep library collection card component count in sync (op…
1c5bde6 
…enedx#35734) (openedx#35886)

* fix: keep library collection card component count in sync (openedx#35734)

Fixed component counter synchronization in these cases:

* When deleting a component inside a collection.
* With the library published, when adding a new component in a collection and reverting library changes.
* With the library published, when deleting a component inside a collection and reverting library changes.

Also adds a published > num_counts field in collections in the search index.

* fix: remove learner_downloadable field references from libraries (openedx#35788)

Also bumps openedx-learning to v0.17.0, which no longer has this field.

* chore: Update common_contraints.txt

---------

Co-authored-by: Cristhian Garcia <crisgarta8@gmail.com>
Waleed-Mujahid pushed a commit to edly-io/edx-platform that referenced this pull request Aug 4, 2025
@ChrisChV @Ian2012 @Waleed-Mujahid
[sumac] fix: keep library collection card component count in sync (op…
a50a492 
…enedx#35734) (openedx#35886)

* fix: keep library collection card component count in sync (openedx#35734)

Fixed component counter synchronization in these cases:

* When deleting a component inside a collection.
* With the library published, when adding a new component in a collection and reverting library changes.
* With the library published, when deleting a component inside a collection and reverting library changes.

Also adds a published > num_counts field in collections in the search index.

* fix: remove learner_downloadable field references from libraries (openedx#35788)

Also bumps openedx-learning to v0.17.0, which no longer has this field.

* chore: Update common_contraints.txt

---------

Co-authored-by: Cristhian Garcia <crisgarta8@gmail.com>
Waleed-Mujahid pushed a commit to edly-io/edx-platform that referenced this pull request Aug 4, 2025
@ChrisChV @Ian2012 @Waleed-Mujahid
[sumac] fix: keep library collection card component count in sync (op…
2d5e3f1 
…enedx#35734) (openedx#35886)

* fix: keep library collection card component count in sync (openedx#35734)

Fixed component counter synchronization in these cases:

* When deleting a component inside a collection.
* With the library published, when adding a new component in a collection and reverting library changes.
* With the library published, when deleting a component inside a collection and reverting library changes.

Also adds a published > num_counts field in collections in the search index.

* fix: remove learner_downloadable field references from libraries (openedx#35788)

Also bumps openedx-learning to v0.17.0, which no longer has this field.

* chore: Update common_contraints.txt

---------

Co-authored-by: Cristhian Garcia <crisgarta8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

Assignees

No one assigned

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChrisChV @openedx-webhooks @bradenmacdonald @mphilbrick211 @Ian2012