-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add sysadmin dashboard #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
deleting and loading courses, for seeing log of git imports of courseware. Includes script for importing course XML from github site.
|
What's the status of this pull request? Is anyone looking into it? |
…uang/sysadmin-dashboard-mongook Conflicts: lms/envs/dev.py
|
MIT would like this feature added to edX platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're trying to make all code internationalizable from here out. Ping me if you need a pointer on how to do this...
…uang/sysadmin-dashboard-mongook
more portable to different installation types and situations.
…-mongook This is a major revamp to make the sysadmin dashboard testable and
… on manual import
…-mongook Added additional loggers for storing in mongo instead of just showing on manual import
lms/djangoapps/dashboard/sysadmin.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Don't need two lines for this.
lms/djangoapps/dashboard/sysadmin.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment doesn't make sense anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, in python 2.7, you can use {c.id: c for c in courses} to create a dictionary.
… and other optimizations
…rsongee/edx-platform into feature/cg/sysadmin-dashboard-mongook Conflicts: lms/djangoapps/dashboard/sysadmin.py lms/djangoapps/dashboard/tests/test_sysadmin.py
…-mongook Feature/cg/sysadmin dashboard mongook
…uang/sysadmin-dashboard-mongook Conflicts: lms/envs/dev.py
…-mongook MITX_ and mitxmako removal from master refactor
|
I've made the requested changes, Ike merged onto the current master, and I handled the refactor of the feature flag and mako names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could just be course_id = kwargs.get('course_id')
|
My one major ask at this point is to clean up the commit history. We've been trying to reduce the number of commits in master that are essentially cleanup on previous commits. However, I'd wait to do that. We'd like to get another set of eyes from over here at edX to look this over before we merge, and it'll probably be easier to squash everything at the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd probably be better off using GitPython rather than using subprocess to call the git binary. We already have GitPython in our requirements files, so it should already be installed.
Corrected exceptions to use exception logging Corrected bad default value in aws.py for MONGODB_LOG Simplified mongouri format string
…-mongook Bug fixes and refactors to sysadmin dashboard
|
I fixed up somethings based on @singingwolfboy comments. I'll have to take a look at moving to GitPython, it doesn't look like it should be too tricky, but I'm afraid I don't really have a lot of time right now to migrate it. Any chance we could leave that as future work, or do you want that in before merge? With how big this branch is, and that it was merged several times instead of rebased I think I would prefer to just cherry pick the relevant commits here into a new branch, squash them, and reference that here,unless someone has some guidance on how to easily do an interactive rebase on several hundred commits that aren't related. If so, I'm all ears as it would be nice to keep this all contained in one PR. |
|
@carsongee I'm OK with leaving the move to GitPython for future work, rather than blocking this PR for it. And yes, I think that making a new branch with a clean history makes a lot of sense; referencing this pull request from that one should work just fine. |
|
This is all cleaned up as a single commit in #1942 |
…location-url make the test ajax_url format consistent with real code
Bump Group Work v2 Hash
…net-id Make the clean_affiliation sets into dictionaries
The theme directory path for `/edx/app/edx-themes/` didn't include the `/edx-platform/` directory and was throwing an error that it couldn't find my theme. This path update should fix that. Update for #654
This PR provides an integrated dashboard for a sysadmin to be able to:
Included is a script which can be used to load course XML content from github. Note that the git import logging and log viewing requires mongoengine (http://mongoengine.org/).
This functionality is enabled by the new
FEATURES["ENABLE_SYSADMIN_DASHBOARD"]flag.This code is in use in the production residential MITx systems at MIT.