-
Notifications
You must be signed in to change notification settings - Fork 4.2k
add sysadmin dashboard for Studio #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
what is the relationship between this and #654 ? |
|
This one is for the CMS; #654 is for the LMS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensure_csrf?
|
What's the status of this pull request? It looks like it's gone stale. |
|
This feature is in production at MIT, and has been for about two months. |
|
Rebased to resolve conflicts |
|
@ichuang - added I18N support. Did a quick spot check to see if I broke anything. Can you verify? Some one the UI looks pretty wonky.... can you verify that's the way it should look. Also, I can't run the delete function - I get this exception: [Errno 2] No such file or directory: u'DATA-BACKUP/course-ppp-dump-Wed_Oct_16_21:23:45_2013.json' Seems like we need to make that path configurable |
|
added settings config for Does this run for you now? |
|
settings.getattr(...) should be getattr(settings,...). fixed. delete seems to work now. |
|
thanks for the fix |
|
Can you verify the UI is what you want? When I delete course, the 'yes' confirmation is way to the right of the page |
|
that's deliberate - the "yes" is supposed to be hard to accidentally click. Just took a look. The extra-large edX studio logo is a bit wonky, probably css thing, but acceptable. All the UI elements are functional, albeit plain. It's what we made. |
|
OK, I have a bunch of meeting in the morning so I should be able to finish this up later up this afternoon.. |
|
This needs tests, so that we can be sure that it stays working as other functionality in the platform changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an odd docstring: a) It isn't attached to anything (module, class, function). b) It doesn't actually include any description. If it's intended as a comment, please just use #.
|
This has a number of obvious pylint and pep8 violations. Please run |
|
needed to rebase again. |
|
Added some stuff to address @cpennington's concerns. I also put this page on a MIT_FEATURES configuration switch as edX wouldn't want this in production mainly because of the potential for accidental data loss - we have a Delete Course story which have a lot of safeguards. Will do a few more items today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this view is @login_required, request.user will always be set.
|
With the acceptance of the LMS sysadmin dashboard, this is no longer needed. The only thing from it we need to take a look at is that it's more broad delete function removes orphaned mongo nodes and doesn't get caught up by duplicate mongo store items. I've added it to my task list to look into that. |
show full sidebar title; blockquote and list styles for comments
…0.2.3 Bumping version of rocket chat xblock to 0.2.3
It is useful for sysadmin staff to be able to:
.tar.gzfiles with errors.This PR provides those features, via a rudimentary but functional dashboard.
No tests provided.