feat: add publicKey param to package initialization parameters#33
Merged
feat: add publicKey param to package initialization parameters#33
Conversation
karrui
changed the title
`publicKey` and `mode` is typed to be mutually exclusive (for now, foresee removing mode entirely in the future).
If not given, then the app will fallback to its previous implementation and use the static public keys.
That's a lot of typing type.
karrui
force-pushed
the
feat/add-built-types
branch
from
18eccc8 to
495d8aa
Compare
liangyuanruo
approved these changes
Jun 5, 2020
liangyuanruo
pushed a commit
that referenced
this pull request
Jan 27, 2021
* feat: add publicKey param to PackageInitParams type `publicKey` and `mode` is typed to be mutually exclusive (for now, foresee removing mode entirely in the future). * feat: add comment on new PackageInitParams shape in init function * feat: use publicKey if given in PackageInitParams If not given, then the app will fallback to its previous implementation and use the static public keys. * feat: add `homeno` possible field type in FieldType type That's a lot of typing type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I don't know why I named my branch the way I named it)
This PR adds a
publicKeykey option for the initialisation parameter for this package.If the
publicKeykey is given, then all signing, webhook, and verification keys will be using the given public key instead of the package fallback keys.Closes #30