refactor: update webhooks HOF to Webhooks class#34
Merged
Conversation
karrui
force-pushed
the
feat/class-based-subpackages
branch
from
fdfa627 to
3d4fcce
Compare
karrui
force-pushed
the
feat/add-built-types
branch
from
18eccc8 to
495d8aa
Compare
liangyuanruo
previously approved these changes
Jun 5, 2020
Contributor
liangyuanruo
left a comment
liangyuanruo
left a comment
There was a problem hiding this comment.
LGTM. I'm glad we got rid of the internal _functions.
karrui
force-pushed
the
feat/class-based-subpackages
branch
from
3d4fcce to
92358d5
Compare
arshadali172
suggested changes
Jun 10, 2020
liangyuanruo
approved these changes
Jun 11, 2020
liangyuanruo
pushed a commit
that referenced
this pull request
Jan 27, 2021
* feat: add new errors.ts file containing MissingSecretKeyError * feat: add util/webhooks.ts for helper methods used by Webhooks class * feat: rewrite webhooks.ts functions as Webhooks class and use in init * test(Webhooks): update tests to use new class based instantiation * test: extract out commonly used functions across tests * feat: add WebhookAuthenticateError class * test: add tests for 100% coverage of Webhooks class * refactor: move webhook signature malform check into util
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part one of the refactor, meant to keep the PR size manageable.
Related to #31
The current chain is:
master -> webhooks (this)