Conversation
this prevents the entire formsg sdk module from being marked as deprecated
This partly reverts commit bccad0a.
89eddd3 to
8cb736f
Compare
Contributor
Author
|
@liangyuanruo i've tested it on local with this commit, all works as they should. |
8cb736f to
2f3e852
Compare
liangyuanruo
approved these changes
Feb 22, 2021
8ae4b7a to
9b6b243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #34, #36, #38 but removed the
publicKeyparameter after extensive discussion with @liangyuanruoReasons for removal
Would be easier to actually update the sdk and make users update??