build: add separate keypairs for dev environment#73
Merged
mantariksh merged 5 commits intodevelopfrom Jun 17, 2021
Merged
Conversation
liangyuanruo
approved these changes
Jun 16, 2021
Contributor
Author
|
whoops, took a look at the key lengths and realised I should have generated these using |
karrui
approved these changes
Jun 17, 2021
Contributor
karrui
left a comment
karrui
left a comment
There was a problem hiding this comment.
thanks for the catch, somehow slipped my attention that test's secretKey is so much longer haha
Contributor
sorry for misleading - should we add a test for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev environment currently uses the same key pairs as staging. This makes it difficult for developers to onboard onto this and the main FormSG repos, as they need access to the staging private keys in order to do dev work.
This PR adds separate signing and verification key pairs for the development environment. These can be used as defaults in the main FormSG repo.
Closes #68