Skip to content

Write segment data on set#1107

Merged
conico974 merged 4 commits intomainfrom
conico/fix-ppr
Feb 9, 2026
Merged

Write segment data on set#1107
conico974 merged 4 commits intomainfrom
conico/fix-ppr

Conversation

@conico974
Copy link
Copy Markdown
Contributor

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 6, 2026

🦋 Changeset detected

Latest commit: bec7b1b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 6, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/aws@1107

commit: bec7b1b

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 28.05% 2925 / 10425
🔵 Statements 28.05% 2925 / 10425
🔵 Functions 51.53% 151 / 293
🔵 Branches 76.54% 741 / 968
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/cache.ts 90.33% 85.71% 100% 90.33% 22-23, 87-95, 193-194, 391-399, 433-434, 468-477, 487-495
packages/open-next/src/types/cache.ts 0% 0% 0% 0%
Generated in workflow #1730 for commit bec7b1b by the Vitest Coverage Report Action

Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conico974 this looks good, any reason why this is still in draft?

@conico974
Copy link
Copy Markdown
Contributor Author

I haven't added test for it, not sure where or how yet. And I'm still AFK today 😉. But otherwise it works

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Feb 8, 2026

And I'm still AFK today

Same here, let's look next week when we are closer to a keyboard ;)

@conico974 conico974 marked this pull request as ready for review February 9, 2026 21:29
@conico974 conico974 requested a review from vicb February 9, 2026 21:29
Comment thread packages/tests-unit/tests/adapters/cache.test.ts
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question
Thanks Nico!

Copy link
Copy Markdown
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I just hope that Meta and Vercel properly sanitize postponed and that we don't see another CVE soon.

@conico974 conico974 merged commit 0344a7d into main Feb 9, 2026
3 checks passed
@conico974 conico974 deleted the conico/fix-ppr branch February 9, 2026 22:14
conico974 added a commit to opennextjs/adapters-api that referenced this pull request Feb 15, 2026
conico974 added a commit to opennextjs/adapters-api that referenced this pull request Mar 21, 2026
conico974 added a commit to opennextjs/adapters-api that referenced this pull request Mar 29, 2026
* ppr support

* fix experimental in aws

* port opennextjs/opennextjs-aws#1107

* add support for segment in PPR

* fix composable cache

* fix experimental test

* make PPR work in cloudflare

* bump to 16.2.1

* port pr opennextjs/opennextjs-cloudflare#1151

* fix composable cache cloudflare

* fix: update Open-Graph tests to skip and assert cache behavior

* format

* fix: update revalidate tag test to assert "MISS" for x-nextjs-cache header

* enable experimental for cf

* fix: rename build:worker script to build:worker:cf for clarity

* fix: skip test for cached fetch in ISR due to unresolved issues

* basic review

* review
conico974 added a commit to opennextjs/adapters-api that referenced this pull request Mar 29, 2026
* Add SKILL.md for porting PRs and AGENTS.md for coding guidelines

* update skill

* Port opennextjs/opennextjs-aws#1118 as a test

* Port opennextjs/opennextjs-aws#1117

* update skill

* Port opennextjs/opennextjs-aws#1114

* Port PR opennextjs/opennextjs-aws#1107

* update skills

* Port PR opennextjs/opennextjs-aws#1108

* Port PR opennextjs/opennextjs-aws#1104

* Port PR opennextjs/opennextjs-aws#1101

* Port PR opennextjs/opennextjs-aws#1098

* review
conico974 added a commit to opennextjs/adapters-api that referenced this pull request Mar 29, 2026
* Add SKILL.md for porting PRs and AGENTS.md for coding guidelines

* update skill

* Port opennextjs/opennextjs-aws#1118 as a test

* Port opennextjs/opennextjs-aws#1117

* update skill

* Port opennextjs/opennextjs-aws#1114

* Port PR opennextjs/opennextjs-aws#1107

* update skills

* Port PR opennextjs/opennextjs-aws#1108

* Port PR opennextjs/opennextjs-aws#1104

* Port PR opennextjs/opennextjs-aws#1101

* Port PR opennextjs/opennextjs-aws#1098

* chore: port PR #1083 from source repository

opennextjs/opennextjs-cloudflare#1083

Changeset: .changeset/port-pr-1083.md

* chore: port PR #1105 from source repository

opennextjs/opennextjs-cloudflare#1105

Changeset: .changeset/port-pr-1105.md

* chore: port PR #1097 from source repository

opennextjs/opennextjs-cloudflare#1097

Changeset: .changeset/port-pr-1097.md

* chore: port PR #1122 from source repository

opennextjs/opennextjs-cloudflare#1122

Applied bugfixes and improvements to the 'migrate' command:
- Fixed extra newlines when appending to files (updated conditionalAppendFileSync signature)
- Fixed error when 'public' directory is missing (creates parent directories automatically)
- Fixed Next.js config file update to check if the file exists first
- Updated checkRunningInsideNextjsApp to accept { appPath: string } instead of full BuildOptions

Changesets:
- .changeset/port-pr-1122-cloudflare.md
- .changeset/port-pr-1122-aws.md

* chore: update port PR skill instructions for staging and committing changes

* chore: port PR #1126 from source repository

opennextjs/opennextjs-cloudflare#1126

Fix: prevent Worker hang on HEAD requests to static assets

When run_worker_first is enabled, HEAD requests to static assets hang
the Worker because response.body is null (per HTTP spec) and the
fallback new ReadableStream() creates a stream that never closes.

Changes:
- Return null body for HEAD requests instead of falling through to
the hanging ReadableStream fallback
- Add tests for maybeGetAssetResult covering GET, HEAD, 404, POST,
and run_worker_first=false cases

Changeset: .changeset/port-pr-1126.md

* linting

* chore: port PR #1127 from source repository

opennextjs/opennextjs-cloudflare#1127

Changeset: .changeset/port-pr-1127.md

* chore: port PR #1138 from source repository

opennextjs/opennextjs-cloudflare#1138

Changeset: .changeset/port-pr-1138.md

* chore: port PR #1133 from source repository

opennextjs/opennextjs-cloudflare#1133

Changeset: .changeset/port-pr-1133.md

Update the migrate command to attempt to create an R2 bucket for caching
as part of the migration process, if that is not possible an application
without caching enabled will be generated instead.

* chore: port PR #1142 from source repository

opennextjs/opennextjs-cloudflare#1142

Changeset: .changeset/port-pr-1142.md

* chore: port PR #1147 from source repository

opennextjs/opennextjs-cloudflare#1147

make dev /cdn-cgi/image behaves like prod for consistency

Changeset: .changeset/port-pr-1147.md

* chore: port PR #1150 from source repository

opennextjs/opennextjs-cloudflare#1150

Changeset: .changeset/port-pr-1150.md

* fix lockfile

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants