Skip to content

In the migrate command, add an initial step to create a Next.js config file (required by open-next) if it doesn't exist#1127

Merged
vicb merged 11 commits intomainfrom
dario/DEVX-2461/create-next-config-in-migrate
Feb 13, 2026
Merged

In the migrate command, add an initial step to create a Next.js config file (required by open-next) if it doesn't exist#1127
vicb merged 11 commits intomainfrom
dario/DEVX-2461/create-next-config-in-migrate

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Contributor

@dario-piotrowicz dario-piotrowicz commented Feb 12, 2026 •
edited
Loading

Fixes https://jira.cfdata.org/browse/DEVX-2461

The next config file is generally present in Next.js apps but it's not actually mandatory (for example see: https://github.com/vercel/examples/tree/main/solutions/blog).

In any case open-next does require the file (see: opennextjs/opennextjs-aws#1111), so the changes here improve the migrate command to create this file if not already present (enabling a migration for projects that don't include the file).

@dario-piotrowicz
In the migrate command, add an initial step to create a Next.js con…
3d67991 
…fig file (required by open-next) if it doesn't exist
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 12, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 6d0343a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 12, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@1127

commit: 6d0343a

vicb
vicb reviewed Feb 12, 2026
View reviewed changes
Comment thread packages/cloudflare/src/cli/build/build.ts Outdated
vicb
vicb reviewed Feb 12, 2026
View reviewed changes
Comment thread packages/cloudflare/src/cli/commands/migrate.ts Outdated
vicb
vicb reviewed Feb 12, 2026
View reviewed changes
Comment thread packages/cloudflare/src/cli/commands/migrate.ts Outdated
vicb
vicb reviewed Feb 12, 2026
View reviewed changes
Comment thread packages/cloudflare/src/cli/commands/migrate.ts Outdated
"Error: This does not appear to be a Next.js application.\n" +
"The 'next' package is not installed and no next.config file was found."
);
process.exit(1);
Copy link
Copy Markdown
Contributor

@vicb vicb Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensureNextConfigExists is a pretty generic name. I would throw here and let the caller decide if they should log the error and/or process.exit. WDYT.

Copy link
Copy Markdown
Contributor Author

@dario-piotrowicz dario-piotrowicz Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rgardingprocess.exit, I put it here as that seemed to me the general pattern in the open-next codebase, I'm happy to throw instead and have the caller exit 👍

Copy link
Copy Markdown
Contributor Author

@dario-piotrowicz dario-piotrowicz Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensureNextConfigExists is a pretty generic name

I've updated the name to createNextConfigFileIfMissing I hope this is better?

Copy link
Copy Markdown
Contributor Author

@dario-piotrowicz dario-piotrowicz Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In regards to process.exit, what do you think about
75229f9
?

vicb
vicb reviewed Feb 12, 2026
View reviewed changes
Comment thread packages/cloudflare/src/cli/commands/migrate.ts Outdated
process.exit(1);
}

printStepTitle("Creating next.config.ts");
Copy link
Copy Markdown
Contributor

@vicb vicb Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I don't think think should be the (single) responsibility of ensureNextConfigExists to do that ?

Copy link
Copy Markdown
Contributor Author

@dario-piotrowicz dario-piotrowicz Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed the function createNextConfigFileIfMissing and removed the printStepTitle, does this work for you?

vicb
vicb reviewed Feb 12, 2026
View reviewed changes
Comment thread packages/cloudflare/src/cli/commands/migrate.ts Outdated
vicb
vicb reviewed Feb 12, 2026
View reviewed changes
Comment thread packages/cloudflare/src/cli/commands/migrate.ts Outdated
dario-piotrowicz and others added 2 commits February 12, 2026 17:34
@dario-piotrowicz @vicb
Update packages/cloudflare/src/cli/commands/migrate.ts
e3a3788 
Co-authored-by: Victor Berchet <victor@suumit.com>
@dario-piotrowicz @vicb
Update packages/cloudflare/src/cli/commands/migrate.ts
af7f2e6 
Co-authored-by: Victor Berchet <victor@suumit.com>
vicb
vicb reviewed Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry quick review but at least some of the comment should be meaningful

vicb
vicb reviewed Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I think you need to update the usage of ensureNextjsVersionSupported ?

Comment thread packages/cloudflare/src/cli/commands/utils.ts
Comment thread packages/cloudflare/src/cli/commands/migrate.ts Outdated
}
);
}
// At this point we're sure the next config exists
Copy link
Copy Markdown
Contributor

@vicb vicb Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: we are sure that it has been created... not that it (still) exists. Not asking any change here.

Copy link
Copy Markdown
Contributor Author

@dario-piotrowicz dario-piotrowicz Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 😄

Anyways I've improved this a bit: 23ea438, is this better? 🙂

Comment thread packages/cloudflare/src/cli/commands/migrate.ts Outdated
Comment on lines +297 to +299
if (!skipNextVersionCheck && !ensureNextjsVersionSupported({ nextVersion })) {
throw new Error(`Next.js version ${nextVersion} is not compatible with OpenNext.`);
}
Copy link
Copy Markdown
Contributor

@vicb vicb Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be just:

Suggested change
if (!skipNextVersionCheck && !ensureNextjsVersionSupported({ nextVersion })) {
throw new Error(`Next.js version ${nextVersion} is not compatible with OpenNext.`);
}
if (!skipNextVersionCheck) {
ensureNextjsVersionSupported({ nextVersion });
}

Copy link
Copy Markdown
Contributor Author

@dario-piotrowicz dario-piotrowicz Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course! 🤦

Copy link
Copy Markdown
Contributor Author

@dario-piotrowicz dario-piotrowicz Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: 6d0343a 👍

vicb
vicb approved these changes Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Dario!

@vicb vicb merged commit 2b437f1 into main Feb 13, 2026
7 checks passed
@vicb vicb deleted the dario/DEVX-2461/create-next-config-in-migrate branch February 13, 2026 17:00
@workers-frameworks workers-frameworks mentioned this pull request Feb 13, 2026
Merged
conico974 added a commit to opennextjs/adapters-api that referenced this pull request Mar 21, 2026
@conico974
chore: port PR #1127 from source repository
79c5af3 
opennextjs/opennextjs-cloudflare#1127

Changeset: .changeset/port-pr-1127.md
conico974 added a commit to opennextjs/adapters-api that referenced this pull request Mar 29, 2026
@conico974
Port multiple PRs from source repositories (#26)
af85bba 
* Add SKILL.md for porting PRs and AGENTS.md for coding guidelines

* update skill

* Port opennextjs/opennextjs-aws#1118 as a test

* Port opennextjs/opennextjs-aws#1117

* update skill

* Port opennextjs/opennextjs-aws#1114

* Port PR opennextjs/opennextjs-aws#1107

* update skills

* Port PR opennextjs/opennextjs-aws#1108

* Port PR opennextjs/opennextjs-aws#1104

* Port PR opennextjs/opennextjs-aws#1101

* Port PR opennextjs/opennextjs-aws#1098

* chore: port PR #1083 from source repository

opennextjs/opennextjs-cloudflare#1083

Changeset: .changeset/port-pr-1083.md

* chore: port PR #1105 from source repository

opennextjs/opennextjs-cloudflare#1105

Changeset: .changeset/port-pr-1105.md

* chore: port PR #1097 from source repository

opennextjs/opennextjs-cloudflare#1097

Changeset: .changeset/port-pr-1097.md

* chore: port PR #1122 from source repository

opennextjs/opennextjs-cloudflare#1122

Applied bugfixes and improvements to the 'migrate' command:
- Fixed extra newlines when appending to files (updated conditionalAppendFileSync signature)
- Fixed error when 'public' directory is missing (creates parent directories automatically)
- Fixed Next.js config file update to check if the file exists first
- Updated checkRunningInsideNextjsApp to accept { appPath: string } instead of full BuildOptions

Changesets:
- .changeset/port-pr-1122-cloudflare.md
- .changeset/port-pr-1122-aws.md

* chore: update port PR skill instructions for staging and committing changes

* chore: port PR #1126 from source repository

opennextjs/opennextjs-cloudflare#1126

Fix: prevent Worker hang on HEAD requests to static assets

When run_worker_first is enabled, HEAD requests to static assets hang
the Worker because response.body is null (per HTTP spec) and the
fallback new ReadableStream() creates a stream that never closes.

Changes:
- Return null body for HEAD requests instead of falling through to
the hanging ReadableStream fallback
- Add tests for maybeGetAssetResult covering GET, HEAD, 404, POST,
and run_worker_first=false cases

Changeset: .changeset/port-pr-1126.md

* linting

* chore: port PR #1127 from source repository

opennextjs/opennextjs-cloudflare#1127

Changeset: .changeset/port-pr-1127.md

* chore: port PR #1138 from source repository

opennextjs/opennextjs-cloudflare#1138

Changeset: .changeset/port-pr-1138.md

* chore: port PR #1133 from source repository

opennextjs/opennextjs-cloudflare#1133

Changeset: .changeset/port-pr-1133.md

Update the migrate command to attempt to create an R2 bucket for caching
as part of the migration process, if that is not possible an application
without caching enabled will be generated instead.

* chore: port PR #1142 from source repository

opennextjs/opennextjs-cloudflare#1142

Changeset: .changeset/port-pr-1142.md

* chore: port PR #1147 from source repository

opennextjs/opennextjs-cloudflare#1147

make dev /cdn-cgi/image behaves like prod for consistency

Changeset: .changeset/port-pr-1147.md

* chore: port PR #1150 from source repository

opennextjs/opennextjs-cloudflare#1150

Changeset: .changeset/port-pr-1150.md

* fix lockfile

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dario-piotrowicz @vicb