Skip to content

Conversation

@egouden
Copy link
Contributor

@egouden egouden commented Nov 22, 2025

This is a pragmatic solution to the infamous shared HDF5 library issue.

The specific changes are proposed by Junie and might need further review.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.51%. Comparing base (6496432) to head (74aebe3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   93.52%   93.51%   -0.01%     
==========================================
  Files          27       27              
  Lines        5572     5568       -4     
==========================================
- Hits         5211     5207       -4     
  Misses        361      361              
Flag Coverage Δ
notebooktests 0.00% <0.00%> (ø)
unittests 93.51% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmuehlbauer
Copy link
Collaborator

@egouden h5netcdf might not be able to read some CfRadial1 files, if they predate netCDF4. So we have to be careful here. I'd like to hear others opinions on that.

Another solution would be to update documentation with some explanation. One more solution would be to make dependencies lazy, so users can install whatever they want.

@egouden
Copy link
Contributor Author

egouden commented Dec 9, 2025

The installation steps in the contributing guide have been updated to avoid this conflict when running the tests on Linux. See #315.

Installing with pip is more convenient for the user but remains unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants