-
Notifications
You must be signed in to change notification settings - Fork 22
enhance contributing experience #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
egouden
commented
Dec 9, 2025
- update guide
- update requirements
* update guide * update requirements
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
There are some files not deleted after notebook tests. @kmuehlbauer Is there a quick fix? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 27 27
Lines 5587 5587
=======================================
Hits 5224 5224
Misses 363 363
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bad6845 to
951ab19
Compare
Need to look this up. We might be able to get away with this, if we run the tests in a dedicated test folder, which will be cleared afterwards. |
kmuehlbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but will require additional maintenance. We should take that path, it will make life easier for users new to the field.
Only one question regarding pre-commit.
CONTRIBUTING.md
Outdated
|
|
||
| ```bash | ||
| git add your-new-file.py | ||
| pre-commit run --all-files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to tell the user to do pre-commit install once before running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would let the developer decides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then maybe mentioning that in the paragraph would make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The guide should be concise. Let's recommend pre-commit install by default !
I think this fix should be integrated in the PR. |
See #316 for a fix. |
|
@egouden Please add an entry to history.md. Thanks! |