Skip to content

Conversation

@egouden
Copy link
Contributor

@egouden egouden commented Dec 9, 2025

  • update guide
  • update requirements

* update guide
* update requirements
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@egouden
Copy link
Contributor Author

egouden commented Dec 9, 2025

There are some files not deleted after notebook tests. @kmuehlbauer Is there a quick fix?

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.50%. Comparing base (727434c) to head (2a438d4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          27       27           
  Lines        5587     5587           
=======================================
  Hits         5224     5224           
  Misses        363      363           
Flag Coverage Δ
notebooktests 0.00% <ø> (ø)
unittests 93.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmuehlbauer
Copy link
Collaborator

There are some files not deleted after notebook tests. @kmuehlbauer Is there a quick fix?

Need to look this up. We might be able to get away with this, if we run the tests in a dedicated test folder, which will be cleared afterwards.

Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but will require additional maintenance. We should take that path, it will make life easier for users new to the field.

Only one question regarding pre-commit.

CONTRIBUTING.md Outdated

```bash
git add your-new-file.py
pre-commit run --all-files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to tell the user to do pre-commit install once before running?

Copy link
Contributor Author

@egouden egouden Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would let the developer decides.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then maybe mentioning that in the paragraph would make sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guide should be concise. Let's recommend pre-commit install by default !

@egouden
Copy link
Contributor Author

egouden commented Dec 10, 2025

There are some files not deleted after notebook tests. @kmuehlbauer Is there a quick fix?

Need to look this up. We might be able to get away with this, if we run the tests in a dedicated test folder, which will be cleared afterwards.

I think this fix should be integrated in the PR.

@egouden egouden marked this pull request as ready for review December 10, 2025 11:15
@kmuehlbauer
Copy link
Collaborator

There are some files not deleted after notebook tests. @kmuehlbauer Is there a quick fix?

Need to look this up. We might be able to get away with this, if we run the tests in a dedicated test folder, which will be cleared afterwards.

I think this fix should be integrated in the PR.

See #316 for a fix.

@kmuehlbauer
Copy link
Collaborator

@egouden Please add an entry to history.md. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants