Conversation
Fixes #26. ehrQL was updated to Python 3.13, but the configuration here was not updated. The dev container build was therefore failing as the latest ehrQL version (which was build uses) was incompatible with the Python in the Docker image.
suzannehamilton
left a comment
suzannehamilton
left a comment
There was a problem hiding this comment.
Yep, I think that's all consistent
| @@ -1,4 +1,4 @@ | |||
| FROM mcr.microsoft.com/devcontainers/python:3.11-bullseye | |||
| FROM mcr.microsoft.com/devcontainers/python:3.13-bullseye | |||
There was a problem hiding this comment.
Could we make this based on ehrql:v1
The ms version doesn't nothing that is useful to us, afaict:
https://github.com/devcontainers/images/blob/main/src/python/.devcontainer/Dockerfile
Might require some work to test and customise the entrypoint for devcontainer usage, but might be a good idea?
Might also be a good idea for research-template-docker, too perhaps, depending on how the R issue is resolve, as we have a similar version mismatch thing there.
There was a problem hiding this comment.
AIUI, critial dev features are installed in at the point of codespace creation, not baked into the base image.
There was a problem hiding this comment.
I created #28 from this thread, so the idea wasn't forgotten about (and so that I may link to it from elsewhere).
3 participants
Fixes #26.
ehrQL was updated to Python 3.13, but the configuration here was not updated. The dev container build was therefore failing as the latest ehrQL version (which was build uses) was incompatible with the Python in the Docker image.