Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/devcontainers/python:3.11-bullseye
FROM mcr.microsoft.com/devcontainers/python:3.13-bullseye
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make this based on ehrql:v1

The ms version doesn't nothing that is useful to us, afaict:
https://github.com/devcontainers/images/blob/main/src/python/.devcontainer/Dockerfile

Might require some work to test and customise the entrypoint for devcontainer usage, but might be a good idea?

Might also be a good idea for research-template-docker, too perhaps, depending on how the R issue is resolve, as we have a similar version mismatch thing there.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIUI, critial dev features are installed in at the point of codespace creation, not baked into the base image.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #28 from this thread, so the idea wasn't forgotten about (and so that I may link to it from elsewhere).


# Suppress the codespace's default first run message
# See https://github.com/devcontainers/features/blob/main/src/common-utils/scripts/rc_snippet.sh
Expand Down