Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make this based on ehrql:v1
The ms version doesn't nothing that is useful to us, afaict:
https://github.com/devcontainers/images/blob/main/src/python/.devcontainer/Dockerfile
Might require some work to test and customise the entrypoint for devcontainer usage, but might be a good idea?
Might also be a good idea for research-template-docker, too perhaps, depending on how the R issue is resolve, as we have a similar version mismatch thing there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AIUI, critial dev features are installed in at the point of codespace creation, not baked into the base image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created #28 from this thread, so the idea wasn't forgotten about (and so that I may link to it from elsewhere).